-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SharePoint Tenant Rename #1605
Comments
To add some additional details, [redacted].onmicrosoft.com is the fallback domain for this tenant. The primary domain and name of the tenant are both [redacted]. I am running it with the following command line parameters: Invoke-SCuBA -ProductNames * -CertificateThumbprint [removed for security] -AppID [removed for security] -Organization [redacted] |
Thank you for your report.
and
Since this does report domain information, if you aren't comfortable sharing the results, no worries. Or feel free to obfuscate, redact, or remove anything you like. But it will help us understand how the rename impacts the values here, and how we might detect such a condition. As for getting it to work, the trouble (assuming v1.5.0) is on line 147 in Connection.psm1 where it calculate the domain prefix. You might add the following as a workaround for your specific situation after line 146.
If you change that, start a new PowerShell session and try running ScubaGear again, that should make sure it uses the correct admin URL and not impact running in your other tenant either. If you try it, let me know if the workaround works for you. |
Here is the requested output. Please let me know after you've captured the details so I can remove/obfuscate the post. Thanks for the workaround. I'll try it. `(Get-MgBetaOrganization).VerifiedDomains Capabilities IsDefault IsInitial Name Type Email, OfficeCommunicationsOnline, Intune True False [redacted].com Managed `Get-MgBetaDomain | FT Id,IsDefault,IsInitial,IsVerified Id IsDefault IsInitial IsVerified [redacted].com True False True |
Details have been captured. Thank you. |
I tried executing with the If clause in place to substitute the correct domain prefix. Now I get the error shown below. I do see output for SharePoint Online in the report now though. WARNING: Error running Get-PnPTenantSite: Attempted to perform an unauthorized operation. |
Ah, yes so the InitialDomainPrefix is used to construct both the admin URL and the Site Identity URL. The latter rebuilds the URL in a different place in the code, so you can add the same conditional as before, but add it after line 28 in ExportSharePointProvider.psm1. |
Also, if you are comfortable using ScubaGear from a branch, I created a branch that calculates the admin URL using a different method that should prevent the issue when the tenant has been renamed. The branch is at: Note two changes that go with this.
If you do decided to try this, let me know if it addresses your issue or if it results in similar or other undesirable behavior. |
I have been trying to run ScubaGear against a tenant that I administer and getting errors when authenticating to SharePoint Online. I saw the other issue reported regarding using unattended credentials. That does allow authentication to succeed, but it still reports an error. We have renamed the SharePoint domain name in this tenant. The tool reports the following error:
WARNING: Error running Get-PnPTenant. The remote name could not be resolved: '[redacted]-admin.sharepoint.com'
WARNING: Error running Get-PnPTenantSite. The remote name could not be resolved: '[redacted]-admin.sharepoint.com'
And the resulting report shows the following:
Control ID Requirement Result Criticality Details
MS.SHAREPOINT.1.1v1 External sharing for SharePoint SHALL be limited to Existing guests or Only people in your organization. Error - Test results missing - Report issue on GitHub
It is referring to "[redacted]-admin.sharepoint.com" however the URL for our SharePoint admin port is "[redacted]-admin.sharepoint.com".
The text was updated successfully, but these errors were encountered: