Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Discovered" licenses from notices file showing up in "Declared" field - Google Mavens #583

Open
ariel11 opened this issue Jun 19, 2024 · 2 comments

Comments

@ariel11
Copy link

ariel11 commented Jun 19, 2024

There is a bug with Google Maven packages (maybe other package types too?) where a notices file license data (which should be "discovered" licenses) are erroneously included in the "declared" field.

Example: https://clearlydefined.io/definitions/maven/mavengoogle/com.google.android.gms/play-services-location/21.2.0.

All the info from the third party notices file is being erroneously included in the "declared" field - those should be "discovered" licenses. In this case, the "declared" would be "OTHER" since there's not a SPDX ID for the "Android Software Development Kit License."

image
@ariel11 ariel11 changed the title "Discovered" licenses from NOTICE file showing up in "Declared" field - Google Mavens "Discovered" licenses from notices file showing up in "Declared" field - Google Mavens Jun 19, 2024
@ariel11
Copy link
Author

ariel11 commented Jun 19, 2024

@capfei - I thought we had an open Issue about this already but I couldn't find it?

@elrayle - FYI, this is a significant pain point I am hoping to get on your radar. Happy to chat more.

@qtomlinson
Copy link
Collaborator

@ariel11 @elrayle @capfei Yes, there was a previous similar issue on this. Similar to my comment on that issue: in the ScanCode v30 result, there is no package level license information, so license information for top level files is used to derive the declared license. is_license_text is true for third_party_licenses.txt in ScanCode v30 result, and therefore the licenses matched are used as the declared license. We can rerun this case after ScanCode upgrage PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants