Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue source component when curating described.sourceLocation #106

Open
jeffmcaffer opened this issue Feb 25, 2018 · 5 comments
Open

Queue source component when curating described.sourceLocation #106

jeffmcaffer opened this issue Feb 25, 2018 · 5 comments

Comments

@jeffmcaffer
Copy link
Member

If a curator supplies the sourceLocation for a package, then we should be able to use that information to queue the source for the package. That requires the crawler to either

  • be given this info up front
  • be able to call out to the service to get the definition for the component in question

Consider also the idea of requeuing a package if a curation changing the source location is merged. This might actually be the best way to trigger the flow.

@jeffmcaffer jeffmcaffer added this to the osls-demo milestone Feb 25, 2018
@fossygirl fossygirl removed this from the osls-demo milestone Mar 12, 2018
@jeffmcaffer jeffmcaffer added this to the September milestone Sep 3, 2018
@AlexWebYourmind AlexWebYourmind modified the milestones: September, October Oct 3, 2018
@AlexWebYourmind AlexWebYourmind modified the milestones: October, November 2018 Nov 6, 2018
@storrisi storrisi modified the milestones: December 2018, January 2019 Jan 10, 2019
@storrisi storrisi modified the milestones: January 2019, February 2019 Feb 11, 2019
@storrisi storrisi modified the milestones: February 2019, March 2019 Feb 28, 2019
@storrisi storrisi removed this from the March 2019 milestone Apr 1, 2019
@dabutvin dabutvin changed the title factor in described.sourceLocation when looking for package source to crawl Queue source component when curating described.sourceLocation Apr 26, 2019
@dabutvin
Copy link
Member

updated the title

@dabutvin
Copy link
Member

I think we should hook on the PR being created and queue the referenced source location then
somewhere in the webhook:

await curationService.validateContributions(pr.number, pr.head.sha, curations)

We should check if the curation contains a source location, check if the definition for that source location already exists, if not then queue it for harvesting

@jeffmcaffer
Copy link
Member Author

Created or merged?

@dabutvin
Copy link
Member

I think created would be best.
Someone input a commit hash, let's go harvest it.

This could help with other validation during review too

@jeffmcaffer
Copy link
Member Author

Ah, I see. this is more speculative harvesting. Sounds cool. We should also do merged (or updated). The initial value may be proven incorrect and a new value entered and eventually merged. Need to ensure we get that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants