Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider generating Swagger from JSON schema #289

Open
jeffmcaffer opened this issue Nov 20, 2018 · 3 comments
Open

consider generating Swagger from JSON schema #289

jeffmcaffer opened this issue Nov 20, 2018 · 3 comments
Assignees
Milestone

Comments

@jeffmcaffer
Copy link
Member

In #285 we updated Swagger and the schemas to be shared so there was one source of truth. There is still a gap around patternProperties which show up in the curations schema (and are not supported by Swagger).

There are a couple approaches we can take:

@moranthomas has been looking at this and may have some thoughts.

@jeffmcaffer
Copy link
Member Author

Note: right now I am inclined to defer this unless the generation is really easy. We are only missing patternProperties in one place and while that's a pain, there are lots of other things to do. Open to suggestions and help...

@AlexWebYourmind
Copy link
Contributor

AlexWebYourmind commented Nov 21, 2018

@moranthomas can you spend 1 hour estimating how much work is required (assuming the conversion wework library serves our purpose) to complete the swagger implementation?

Let's make sure to take into account comments on #285, if we realize there's a lot of work involved we can wait until OpenAPI 3.1 is available.

@jeffmendoza
Copy link
Member

Look to see current state

@jeffmendoza jeffmendoza added this to the November 2019 milestone Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants