Purge cloudflare edge cache from the service #503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
April 25, 2019 17:16
dabutvin
reviewed
May 2, 2019
dabutvin
reviewed
May 2, 2019
dabutvin
reviewed
May 2, 2019
dabutvin
reviewed
May 2, 2019
added 2 commits
May 3, 2019 13:09
logging rather than throwing for CDN rt errs
|
This one seems ready now. Kindly take a look to see if we're good to merge. Otherwise, new opportunities are welcome too. Thanks. |
dabutvin
reviewed
May 6, 2019
dabutvin
reviewed
May 28, 2019
| const expand = request.query.expand === '-files' ? '-files' : null // only support '-files' for now | ||
| const result = await definitionService.get(coordinates, pr, force, expand) | ||
| response.set('cache-tag', definitionService.tagFromCoordinates(result)) |
There was a problem hiding this comment.
in order to build the hash correctly this should be
response.set('cache-tag', definitionService.tagFromCoordinates(result.coordinates))
There was a problem hiding this comment.
I understand, you’re right; otherwise any tool additions will make it a different hash. Thanks for catching this!
|
@geneh can you take a look and see if this is ready to merge? |
|
I am closing this pull request. Please check the corresponding #418. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #418