Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No UI for WITH (and no valid SPDX for “GPL-2.0-only-WITH-Classpath-exception-2.0”) #694

Open
ariel11 opened this issue Jan 8, 2020 · 3 comments

Comments

@ariel11
Copy link

ariel11 commented Jan 8, 2020

Currently, the curation UI only has AND / OR buttons. There are about two dozen "exceptions" you would add using "WITH," as specified by the SPDX formatting guidelines - see list here: https://spdx.org/licenses/exceptions-index.html. I think we need to add a "WITH" button to the curation UI.

Additionally, right now the drop-down menu has “GPL-2.0-with-classpath-exception,” which is not in SPDX format. There are a number of glassfish/Oracle components using this license scheme and the SPDX format would be “GPL-2.0-only-WITH-Classpath-exception-2.0.”

There is currently no way to curate the above in correct SPDX format. When I see this I update the yaml file but am running into merged curations that use the non-SPDX format that is available in the drop-down menu (e.g. https://github.com/clearlydefined/curated-data/pull/3242/files). Can we also remove this incorrect, non-SPDX option of “GPL-2.0-with-classpath-exception?"

@geneh geneh transferred this issue from clearlydefined/website Jan 8, 2020
@geneh
Copy link
Contributor

geneh commented Jan 8, 2020

"GPL-2.0-with-classpath-exception" is pulled from the SPDX library: https://github.com/sindresorhus/spdx-license-list/blob/master/licenses/GPL-2.0-with-classpath-exception.json

Another example is Apache v2.0 WITH LLVM exception.

There is certainly a gap in the UI.

@clearlyoss
Copy link

Related to this thread will there be support for custom license types? Often in a scan report we get back license types customized from the standard SPDX license type and it would be great to have the ability to includes this license and upload the text. I believe the SPDX spec supports custom license types.

@ariel11
Copy link
Author

ariel11 commented Nov 2, 2020

Also see clearlydefined/website#878

@nellshamrell nellshamrell removed the bug label Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants