Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facet changes still staged even if you clear the fields before submitting curation #1070

Open
bduranc opened this issue Feb 14, 2025 · 1 comment

Comments

@bduranc
Copy link

bduranc commented Feb 14, 2025

Issue Type: Bug
Issue Description:

If you curate a facet (type in glob expression) and delete it without clicking "Revert", the change still persists when you submit the curation.

In the following test, I populated the doc and test facets with glob expressions and then quickly removed them by hitting back space until both fields were fully clear. I then proceeded to curate the declared license and release date instead, unaware that my original facet values were still staged behind the scenes. The resulting curation PR was submitted with all changes, including the facets even though that was not my intent.

Image

I then submitted a subsequent curation just for the facets alone, but it did not contain anything (possibly due to conflict from previous one?).

@bduranc
Copy link
Author

bduranc commented Feb 14, 2025

There have issues in the past with things unintentionally ending up in curation PRs.
clearlydefined/service#677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant