-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to set the source location to an URL pointing to an archive #801
Comments
@fossygirl @geneh what do you think about this suggestion? |
@storrisi Let's please bring all of these questions to the biweekly meeting so everyone in the community can weigh in. |
Just to be clear, as I read the specs, sourceLocation can already be a sourcearchive, so this is not a new spec feature I'm asking for, but just to expose it through the web UI. |
@sschuberth with the knowledge that sourceLocation must point to an exact commit level of detail can you clarify what "source artifacts" actually means? I suppose, for example, it could point to a tarball? Can you elaborate? I've included a screen shot of the current prompt which shows: Do you have some thoughts about how the UI should look for sourcearchive? I note that despite the big cross product of all combinations of type and provider currently the data only represents a small subset -- and often a provider and type are associated
|
Indeed,
I guess there's no way around adding something like "Custom URL" next to "GitHub" where any URL could be entered. Whether it's valid must be verified by a human as part of reviewing the curation before merging.
Correct, at least the last of my examples ( Note that for cases like |
Thank you @sschuberth for your comments! Based on your examples I propose that the type/provider be chosen for your examples (respectively):
My initial thought about the UI is there should be a combo box or some choice for type. Your last paragraph highlights a question that I have: "How are the curations interpreted based on type/provider"? I'm not sure where to look for this code in either the website or services repos... For example
Finally allow me to add a new question: How much validation of a sourceLocation should the website do while entering a curation? Based on the fully elaborated URL (calculated using the logic from the code that interprets type/provider) should we try to start downloading the artifact (to ensure we don't get a 404 or some other error)? Allow me to note two example curations:
@geneh can you help answer these questions? |
@tmarble This is a lower priority issue. Let's please bring all of these questions to the biweekly meeting so everyone in the community can weigh in. |
Hi, Two questions I have that might be similar to what was being asked previously here...
If the above picture is accurate, then I'm also curious what happens if one of the jar's don't exist? For example with multi-module projects... I.e. like https://repo1.maven.org/maven2/com/google/inject/guice-parent/4.0/, there is no source or binary jar at the parent level. Just some docs and the parent POM. And lastly, is the type of "sourcearchive" still exclusively for the "mavencentral" provider? Thanks and apologies in advance if I'm asking duplicate questions with answers already documented somewhere else :) |
Yes.
At the example of NPM, there is none.
Like you say, the former is the binary artifact whereas the latter is the sources artifact.
I believe a simple file existence check should suffice.
Correct. Which is why I would want to set sourcearchive/mavencentral for antlr/2.7.7 to https://www.antlr2.org/download/antlr-2.7.7.tar.gz. |
Currently, setting the source location triggers a wizard to browse for a GitHub repository. While a VCS location certainly is to be preferred, some sources are only available as source artifacts. Please support setting those as the source location.
The text was updated successfully, but these errors were encountered: