Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright filter under Files section not working consistently #883

Open
bduranc opened this issue Sep 4, 2020 · 2 comments
Open

Copyright filter under Files section not working consistently #883

bduranc opened this issue Sep 4, 2020 · 2 comments

Comments

@bduranc
Copy link

bduranc commented Sep 4, 2020

Issue Type: Bug
Issue Description:

I've noticed that the search filter for the "Copyrights" column under Files section does not actually appear to do anything.

When searching for either a partial copyright string (e.g. "XYZ") or the full string as it's listed under the Licensed section (e.g. "Copyright (c) 2020 XYZ Inc." and clicking the green "Search" button, the page refreshes but the requested filters aren't applied.

image

I expect this feature would operate similar to the other filters in the Files section, where if you enter in your search string, the number of entries will be reduced to just those that match your search filter. This isn't happening for me here.

Furthermore, it might be a good improvement for the attributions to show as a "select" type filter like we see for filtering by License, rather than the plain text field. I can create a separate feature request for this if others agree it's a good idea.

image

Thanks.

@bduranc
Copy link
Author

bduranc commented Sep 4, 2020

Oh, and the Browser I was using when testing this: most recent Google Chrome on a 64-bit Windows system.

@nellshamrell
Copy link
Contributor

Confirmed on https://clearlydefined.io/definitions/npm/npmjs/-/jest-playwright-preset/1.4.3

Repro steps:

Visit https://clearlydefined.io/definitions/npm/npmjs/-/jest-playwright-preset/1.4.3
Under the "Files" heading, click on the magnifying glass next to "Copyrights"
Type in anything (i.e. "MIT")
Click "Search"
You will see that the list of files refreshes to be an empty list

I'm wondering what the original intent of this was?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants