Skip to content

Commit de70b28

Browse files
authored
chore(expo): Mention config plugin in Google Sign-In migration notice (#9019)
1 parent 85b8831 commit de70b28

6 files changed

Lines changed: 10 additions & 5 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@clerk/expo": patch
3+
---
4+
5+
Clarify the native Google Sign-In migration warning to mention the required Expo config plugin.

packages/expo/src/hooks/__tests__/useSignInWithGoogle.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ describe('useSignInWithGoogle', () => {
138138

139139
expect(consoleWarnSpy).toHaveBeenCalledTimes(1);
140140
expect(consoleWarnSpy).toHaveBeenCalledWith(
141-
'Clerk: In the next major version, native Google Sign-In will require installing @clerk/expo-google-signin. The @clerk/expo/google import path will continue to work.',
141+
'Clerk: In the next major version, native Google Sign-In will require installing @clerk/expo-google-signin and adding its Expo config plugin. The @clerk/expo/google import path will continue to work.',
142142
);
143143
} finally {
144144
consoleWarnSpy.mockRestore();

packages/expo/src/hooks/useSignInWithGoogle.android.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export type {
1818
* - No additional dependencies required
1919
*
2020
* In the next major version, apps using native Google Sign-In will need to install
21-
* `@clerk/expo-google-signin` alongside `@clerk/expo`.
21+
* `@clerk/expo-google-signin` alongside `@clerk/expo` and add its Expo config plugin.
2222
*
2323
* @example
2424
* ```tsx

packages/expo/src/hooks/useSignInWithGoogle.ios.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export type {
1818
* - No additional dependencies required
1919
*
2020
* In the next major version, apps using native Google Sign-In will need to install
21-
* `@clerk/expo-google-signin` alongside `@clerk/expo`.
21+
* `@clerk/expo-google-signin` alongside `@clerk/expo` and add its Expo config plugin.
2222
*
2323
* @example
2424
* ```tsx

packages/expo/src/hooks/useSignInWithGoogle.shared.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ function warnAboutGoogleSignInPackageMigration() {
3333

3434
hasWarnedAboutGoogleSignInPackage = true;
3535
console.warn(
36-
'Clerk: In the next major version, native Google Sign-In will require installing @clerk/expo-google-signin. The @clerk/expo/google import path will continue to work.',
36+
'Clerk: In the next major version, native Google Sign-In will require installing @clerk/expo-google-signin and adding its Expo config plugin. The @clerk/expo/google import path will continue to work.',
3737
);
3838
}
3939

packages/expo/src/hooks/useSignInWithGoogle.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export type StartGoogleAuthenticationFlowReturnType = {
2222
* For web platforms, use the OAuth-based Google Sign-In flow instead via useSSO.
2323
*
2424
* In the next major version, apps using native Google Sign-In will need to install
25-
* `@clerk/expo-google-signin` alongside `@clerk/expo`.
25+
* `@clerk/expo-google-signin` alongside `@clerk/expo` and add its Expo config plugin.
2626
*
2727
* @example
2828
* ```tsx

0 commit comments

Comments
 (0)