Don't throw on warnings; don't crash watch-and-recompile on errors

Addresses #40.

Author: alexander-yakushev

src/virgil.clj

@@ -2,12 +2,16 @@
   (:require
    [clojure.java.io :as io]
    [virgil.watch :refer (watch-directory make-idle-callback)]
-   [virgil.compile :refer (compile-all-java java-file?)]))
+   [virgil.compile :refer (compile-all-java java-file?)]
+   virgil.util))
 
 (def watches (atom #{}))
 
 (defn compile-java [directories & {:keys [options verbose]}]
-  (compile-all-java directories options verbose))
+  (let [diags (compile-all-java directories options verbose)]
+    (when (virgil.util/compilation-errored? diags)
+      (throw (ex-info (format "Compilation failed: %d error(s)." (count diags))
+                      {:diagnostics diags})))))
 
 (defn watch-and-recompile [directories & {:keys [options verbose post-hook]}]
   (let [recompile (fn []

src/virgil/compile.clj

@@ -151,10 +151,9 @@
    (let [collector (DiagnosticCollector.)
          options (ArrayList. (vec options))
          name->source (generate-classname->source directories)]
-     (println "Compiling" (count name->source)"Java source files in" directories "...")
+     (println "\nCompiling" (count name->source)"Java source files in" directories "...")
      (binding [*print-compiled-classes* verbose?]
        (compile-java options collector name->source))
      (when-let [diags (seq (.getDiagnostics collector))]
        (print-diagnostics diags)
-       (throw (ex-info (format "Compilation failed: %d error(s)." (count diags))
-                       {:diagnostics diags}))))))
+       diags))))

src/virgil/util.clj

@@ -20,11 +20,14 @@
     (let [k (.getKind d)
           log (infer-print-function k)]
       (if (nil? (.getSource d))
-        (println-err (format "%s: %s\n"
+        (println-err (format "%s: %s"
                              (.toString k)
                              (.getMessage d nil)))
-        (println-err (format "%s: %s, line %d: %s\n"
+        (println-err (format "%s: %s, line %d: %s"
                      (.toString k)
                      (.. d getSource getName)
                      (.getLineNumber d)
                      (.getMessage d nil)))))))
+
+(defn compilation-errored? [diagnostics]
+  (some #(= (.getKind ^Diagnostic %) Diagnostic$Kind/ERROR) diagnostics))

test/ClassWithError.java

@@ -0,0 +1,10 @@
+package virgil;
+
+import java.util.*;
+
+public class ClassWithWarning {
+
+    public static void badReturn() {
+        return 1 + 2;
+    }
+}

test/ClassWithWarning.java

@@ -0,0 +1,11 @@
+package virgil;
+
+import java.util.*;
+
+public class ClassWithWarning {
+
+    public static void rawType() {
+        List list = new ArrayList();
+        list.add("Hello");
+    }
+}

test/virgil_test.clj

@@ -81,3 +81,17 @@
     (cp "B" 'B)
     (wait-until-true #(= 42 (magic-number)))
     (is (= 42 (magic-number)))))
+
+(deftest warnings-shouldnt-throw-test
+  (binding [*dir* (mk-tmp)]
+    (cp "ClassWithWarning" 'ClassWithWarning)
+    (is (nil? (recompile))))
+
+  (binding [*dir* (mk-tmp)]
+    (cp "ClassWithError" 'ClassWithError)
+    (is (thrown? clojure.lang.ExceptionInfo (recompile)))))
+
+(deftest errors-shouldnt-break-watch-and-recompile-test
+  (binding [*dir* (mk-tmp)]
+    (cp "ClassWithError" 'ClassWithError)
+    (is (nil? (virgil/watch-and-recompile [(str *dir*)])))))