Fix arguments to "done" event. refs #15854

git-svn-id: http://svn.dojotoolkit.org/src/dojo/trunk@29487 560b804f-0ae3-0310-86f3-f6aa0a117693

Author: bryanforbes

request/notify.js

@@ -16,7 +16,8 @@ define(['../Evented', '../_base/lang', './util'], function(Evented, lang, util){
 	//		|     }
 	//		| );
 
-	var pubCount = 0;
+	var pubCount = 0,
+		slice = [].slice;
 
 	var hub = lang.mixin(new Evented, {
 		onsend: function(data){
@@ -42,7 +43,7 @@ define(['../Evented', '../_base/lang', './util'], function(Evented, lang, util){
 
 			// After all event handlers have run, run _on* handler
 			if(this['_on' + type]){
-				this['_on' + type].apply(this, arguments);
+				this['_on' + type].apply(this, slice.call(arguments, 1));
 			}
 			return result;
 		}

tests/request/notify.html

@@ -102,9 +102,10 @@
 
 					var doneFired = 0;
 					t.remove = remover(
-						notify('done', function(response){
+						notify('done', d.getTestErrback(function(data){
 							doneFired = 1;
-						}),
+							t.t(data instanceof Error);
+						})),
 						notify('error', d.getTestErrback(function(data){
 							t.t(data instanceof Error);
 							t.f(doneFired, "'error' should have fired before 'done'");