Skip to content

Commit 4a57de1

Browse files
Centrilbfops
andauthored
v8: use fast static strings for known strings (#3351)
# Description of Changes v8: use fast static strings for known strings # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing Covered by existing. --------- Co-authored-by: Zeke Foppa <[email protected]>
1 parent a16bfaa commit 4a57de1

File tree

12 files changed

+538
-286
lines changed

12 files changed

+538
-286
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,12 @@ jobs:
5858
$ErrorActionPreference = 'Stop'
5959
$PSNativeCommandUseErrorActionPreference = $true
6060
61+
# Use a different linker. Otherwise, the build fails with some obscure linker error that
62+
# seems to be a result of us producing a massive PDB file.
63+
# I (@bfops) tried a variety of other link options besides switching linkers, but this
64+
# seems to be the only thing that worked.
65+
$env:RUSTFLAGS='-Clinker=lld-link'
66+
6167
cargo build -p spacetimedb-cli -p spacetimedb-standalone -p spacetimedb-update
6268
Start-Process target/debug/spacetimedb-cli.exe -ArgumentList 'start --pg-port 5432'
6369
cd modules
@@ -395,4 +401,3 @@ jobs:
395401
echo "It looks like the CLI docs have changed:"
396402
exit 1
397403
fi
398-

0 commit comments

Comments
 (0)