Skip to content

Commit e32240b

Browse files
Centrilbfops
andauthored
v8 -> 140.2, s/HandleScope/PinScope/g (#3349)
# Description of Changes Update v8 to 140.2. # API and ABI breaking changes None # Expected complexity level and risk 2 # Testing Future work. --------- Co-authored-by: Zeke Foppa <[email protected]>
1 parent eaeb6b1 commit e32240b

File tree

11 files changed

+488
-171
lines changed

11 files changed

+488
-171
lines changed

.github/workflows/ci.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,16 @@ jobs:
5454
- name: Build and start database (Windows)
5555
if: runner.os == 'Windows'
5656
run: |
57+
# Fail properly if any individual command fails
58+
$ErrorActionPreference = 'Stop'
59+
$PSNativeCommandUseErrorActionPreference = $true
60+
61+
# Use a different linker. Otherwise, the build fails with some obscure linker error that
62+
# seems to be a result of us producing a massive PDB file.
63+
# I (@bfops) tried a variety of other link options besides switching linkers, but this
64+
# seems to be the only thing that worked.
65+
$env:RUSTFLAGS='-Clinker=lld-link'
66+
5767
cargo build -p spacetimedb-cli -p spacetimedb-standalone -p spacetimedb-update
5868
Start-Process target/debug/spacetimedb-cli.exe -ArgumentList 'start --pg-port 5432'
5969
cd modules

0 commit comments

Comments
 (0)