Skip to content

Commit e9558c9

Browse files
bfopsjdetter
authored andcommitted
[bfops/unreal-ci]: comments
1 parent 9a6b980 commit e9558c9

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,10 +245,16 @@ jobs:
245245
246246
unreal_engine_tests:
247247
name: Unreal Engine Tests
248+
# This can't go on e.g. ubuntu-latest because that runner runs out of disk space. ChatGPT suggested that the general solution tends to be to use
249+
# a custom runner.
248250
runs-on: spacetimedb-runner
249251
container:
250252
image: ghcr.io/epicgames/unreal-engine:dev-5.6
251253
credentials:
254+
# Note(bfops): I don't think that `github.actor` needs to match the user that the token is for, because I'm using a token for my account and
255+
# it seems to be totally happy.
256+
# However, the token needs to be for a user that has access to the EpicGames org (see
257+
# https://dev.epicgames.com/documentation/en-us/unreal-engine/downloading-source-code-in-unreal-engine?application_version=5.6)
252258
username: ${{ github.actor }}
253259
password: ${{ secrets.GHCR_TOKEN }}
254260
# Run as root because otherwise we get permission denied for various directories inside the container. I tried doing dances to allow it to run

0 commit comments

Comments
 (0)