Skip to content

Commit 4daa968

Browse files
committed
3834 Rename ops-to-support to rquired-ops, fix typos
1 parent f98ec22 commit 4daa968

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
- Bump the injected `piggieback` to [0.6.1](https://github.com/nrepl/piggieback/blob/master/CHANGES.md#061-2025-12-31).
1212
- Bump the injected `cider-nrepl` to [0.58.0](https://github.com/clojure-emacs/cider-nrepl/blob/master/CHANGELOG.md#0580-2025-10-16).
1313
- * [cider-nrepl#951](https://github.com/clojure-emacs/cider-nrepl/pull/951): Debug: correctly process #dbg tag during load-file.
14-
- [#3834](https://github.com/clojure-emacs/cider/issues/3834): Change cider-ns-refresh to always use Clojure REPL
14+
- [#3834](https://github.com/clojure-emacs/cider/issues/3834): Change cider-ns-refresh to always use Clojure REPL.
1515

1616
### Bugs fixed
1717

cider-connection.el

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1015,11 +1015,11 @@ Returns a list of the form ((session1 host1) (session2 host2) ...)."
10151015
sessions
10161016
:initial-value '()))
10171017

1018-
(defun cider-repls (&optional type ensure ops-to-support)
1018+
(defun cider-repls (&optional type ensure required-ops)
10191019
"Return cider REPLs of TYPE from the current session.
10201020
If TYPE is nil or multi, return all REPLs. If TYPE is a list of types,
10211021
return only REPLs of type contained in the list. If ENSURE is non-nil,
1022-
throw an error if no linked session exists. If OPS-TO-SUPPORT is non-nil,
1022+
throw an error if no linked session exists. If REQUIRED-OPS is non-nil,
10231023
filters out all the REPLs that do not support the designated ops."
10241024
(let ((type (cond
10251025
((listp type)
@@ -1049,7 +1049,7 @@ filters out all the REPLs that do not support the designated ops."
10491049
(and (cider--match-repl-type type b)
10501050
(seq-every-p (lambda (op)
10511051
(nrepl-op-supported-p op b))
1052-
ops-to-support))))
1052+
required-ops))))
10531053
repls)
10541054
(when ensure
10551055
(cider--no-repls-user-error type)))))
@@ -1071,7 +1071,7 @@ session."
10711071
(declare (indent 1))
10721072
(let ((cur-type (cider-repl-type-for-buffer))
10731073
(which-key (or (car-safe which) which))
1074-
(ops-to-support (cdr-safe which)))
1074+
(required-ops (cdr-safe which)))
10751075
(cl-case which-key
10761076
(:clj-strict (when (eq cur-type 'cljs)
10771077
(user-error "Clojure-only operation requested in a ClojureScript buffer")))
@@ -1086,7 +1086,7 @@ session."
10861086
(ensure (cl-case which-key
10871087
(:auto nil)
10881088
(t 'ensure)))
1089-
(repls (cider-repls type ensure ops-to-support)))
1089+
(repls (cider-repls type ensure required-ops)))
10901090
(mapcar function repls))))
10911091

10921092
;; REPLs double as connections in CIDER, so it's useful to be able to refer to

test/cider-connection-tests.el

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -365,8 +365,7 @@
365365
(expect (cider-repls) :to-have-same-items-as (list l1 l2)))))))))
366366

367367
(describe "killed buffers"
368-
(it "do not show up in it
369-
"
368+
(it "do not show up in it"
370369
(let ((default-directory (expand-file-name "/tmp/some-dir")))
371370
(cider-test-with-buffers
372371
(a b)
@@ -401,7 +400,7 @@
401400
(expect (cider-repls) :to-equal (list a b))
402401
(sesman-unregister 'CIDER session))))))
403402

404-
(describe "when ops-to-support is not nil"
403+
(describe "when required-ops is not nil"
405404
:var (nrepl-ops)
406405
(it "only returns the repls that support the given ops"
407406
(let ((proj-dir (expand-file-name "/tmp/proj-dir")))

0 commit comments

Comments
 (0)