From fee1b63c933511f7aac90648d9415b1ff4f19d25 Mon Sep 17 00:00:00 2001 From: Eric Dallo Date: Wed, 9 Apr 2025 10:09:53 -0300 Subject: [PATCH 1/3] Add client-info to clone op --- nrepl-client.el | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/nrepl-client.el b/nrepl-client.el index 454fb2fe5..97d53503e 100644 --- a/nrepl-client.el +++ b/nrepl-client.el @@ -1032,12 +1032,16 @@ ADDITIONAL-PARAMS is a plist to be appended to the request message." connection tooling)) +(defvar cider-version) + (defun nrepl-sync-request:clone (connection &optional tooling) "Sent a :clone request to create a new client session. The request is dispatched via CONNECTION. Optional argument TOOLING Tooling is set to t if wanting the tooling session from CONNECTION." - (nrepl-send-sync-request '("op" "clone") + (nrepl-send-sync-request `("op" "clone" + "client-name" "CIDER" + "client-version" ,cider-version) connection nil tooling)) From 57ce33deca7f9b6eed6077085e5d8e163336b584 Mon Sep 17 00:00:00 2001 From: Eric Dallo Date: Wed, 9 Apr 2025 10:14:48 -0300 Subject: [PATCH 2/3] CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 24a45f924..a4f2cb29f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,6 +25,7 @@ - [#3789](https://github.com/clojure-emacs/cider/issues/3796): Completion: disable client-side sorting (defer to backend-provided candidate order). - [#3797](https://github.com/clojure-emacs/cider/issues/3797): Completion: enable `cider-completion-style` by default (this enables richer completion suggestions where candidates don't have to strictly match the prefix). - [#3803](https://github.com/clojure-emacs/cider/pull/3803): Enable dynamic indentation for `clojure-ts-mode`. +- [#3806](https://github.com/clojure-emacs/cider/pull/3806): Add client info to `clone` op request. ### Bugs fixed From 45a0b9acc6f8d20cd76a08920bd81ebea19b072b Mon Sep 17 00:00:00 2001 From: Eric Dallo Date: Thu, 10 Apr 2025 14:46:51 -0300 Subject: [PATCH 3/3] fix nrepl server mock --- test/nrepl-server-mock.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/nrepl-server-mock.el b/test/nrepl-server-mock.el index 6264eb8d2..d02995bed 100644 --- a/test/nrepl-server-mock.el +++ b/test/nrepl-server-mock.el @@ -43,7 +43,10 @@ requirements." (let* ((msg (queue-dequeue (cdr (nrepl-bdecode output)))) (_ (mock/log! ":mock.filter/msg :in %S" msg)) (response (pcase msg - (`(dict "op" "clone" "id" ,id) + (`(dict "op" "clone" + "client-name" "CIDER" + "client-version" ,cider-version + "id" ,id) `(dict "id" ,id "session" "a-session" "status" ("done")