Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion support for javascript libraries in node_packages #16

Open
markokocic opened this issue Feb 3, 2021 · 1 comment
Open

Completion support for javascript libraries in node_packages #16

markokocic opened this issue Feb 3, 2021 · 1 comment

Comments

@markokocic
Copy link

It would be nice if clj-suitable supported to have completion for Javascript libraries that are already installed in projects node_modules project.

shadow-cljs already supports requiring those libraries and using them as part of the application, but it's not possible to autocomplete them in cider or cursive.

Referenced shadow-cljs issue: thheller/shadow-cljs#834

@vemv vemv pinned this issue Jul 22, 2023
@vemv
Copy link
Member

vemv commented Jul 22, 2023

As a quick note, I wonder if we could reuse javascript-oriented LSP analysis. Running a full-blown lsp server seems error-prone, however perhaps the underlying library can be invoked in a one-off manner, similarly to when one asks clj-kondo for analysis (it runs for a bit, emits files and then it's all done).


...Maybe it's not necessary. Given a ["react-tippy" :as react-tippy] require, surely the cljs analyzer can tell us that react-tippy is a "foreign" object .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants