Skip to content

Tools section#389

Merged
swannodette merged 4 commits intoclojure:masterfrom
dgb23:tools-section
Aug 31, 2021
Merged

Tools section#389
swannodette merged 4 commits intoclojure:masterfrom
dgb23:tools-section

Conversation

@dgb23
Copy link
Contributor

@dgb23 dgb23 commented Jul 11, 2021

In regards to this issue: #387

I added three pages in the tooling section. I think the added tools (vscode and shadow-cljs) warrant mention on the site.

Caveat: The individual pages are small. I specifically didn't use leinigen for ClojureScript for a long time.

To accommodate the changes I suggest to change the navigation like so under tools.ftl:

<a href="vscode" class="w-nav-link clj-section-nav-item-link">Visual Studio Code</a>

<div class="w-nav-link clj-section-nav-heading">Build Tools</div>
<a href="leinigen" class="w-nav-link clj-section-nav-item-link">Leinigen</a>
<a href="shadow-cljs" class="w-nav-link clj-section-nav-item-link">shadow-cljs</a>

@dgb23
Copy link
Contributor Author

dgb23 commented Jul 11, 2021

Forgot to mention: I also changed the jblake link to http. Issue: #388

@dgb23
Copy link
Contributor Author

dgb23 commented Jul 23, 2021

I managed to consistently misspell Leiningen in this PR, which is a bit of a faux pas to say the least...

I plan on cleaning this up if you find this change generally useful. Also if you have other considerations I'm happy hear.

@swannodette
Copy link
Member

swannodette commented Aug 31, 2021

@dgb23 looks like a good start - did you submit your CA?

@puredanger
Copy link
Member

puredanger commented Aug 31, 2021

He is listed as a contributor at https://clojure.org/dev/contributors

@swannodette swannodette merged commit 80a9a02 into clojure:master Aug 31, 2021
@puredanger
Copy link
Member

puredanger commented Aug 31, 2021

I updated the nav and the list page and deployed

@swannodette
Copy link
Member

swannodette commented Aug 31, 2021

@puredanger thanks!

@dgb23
Copy link
Contributor Author

dgb23 commented Sep 6, 2021

In the same commit I added a vscode.adoc which was merged but not linked under "editors". I think calva for vscode deserves mention there, as it is one of the more popular and beginner friendly options for both Clojure and ClojureScript development.

@puredanger
Copy link
Member

puredanger commented Sep 6, 2021

Sorry, I missed that, will add!

eval pushed a commit to eval/clojurescript-site that referenced this pull request Nov 16, 2021
@dgb23 @eval
Tools section (clojure#389)
d27c7ee 
* fixes contributing_site jblake download link

* added tools/vscode

* added tools/leinigen

* added tools/shadow-cljs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dgb23 @swannodette @puredanger