* (wip) externs-var-info, which could be used by both has-extern? and js-tag

* test are failing because
  - we have a bad hack that assumes we have an instance
  - extern-var-info doesn't tell us what the *resolved* prefix is

Author: swannodette

src/main/clojure/cljs/analyzer.cljc

@@ -1030,7 +1030,7 @@
     boolean  Boolean
     symbol   Symbol})
 
-(defn has-extern?*
+(defn extern-var-info
   ([pre externs]
    (let [pre (if-some [me (find
                             (get-in externs '[Window prototype])
@@ -1039,25 +1039,29 @@
                  (into [tag 'prototype] (next pre))
                  pre)
                pre)]
-     (has-extern?* pre externs externs)))
-  ([pre externs top]
+     (extern-var-info pre externs externs nil)))
+  ([pre externs top info]
    (cond
-     (empty? pre) true
+     (empty? pre) info
      :else
      (let [x  (first pre)
            me (find externs x)]
        (cond
-         (not me) false
+         (not me) nil
          :else
          (let [[x' externs'] me
-               xmeta (meta x')]
-           (if (and (= 'Function (:tag xmeta)) (:ctor xmeta))
-             (or (has-extern?* (into '[prototype] (next pre)) externs' top)
-                 (has-extern?* (next pre) externs' top)
+               info' (meta x')]
+           (if (and (= 'Function (:tag info')) (:ctor info'))
+             (or (extern-var-info (into '[prototype] (next pre)) externs' top nil)
+                 (extern-var-info (next pre) externs' top info')
                  ;; check base type if it exists
-                 (when-let [super (:super xmeta)]
-                   (has-extern?* (into [super] (next pre)) externs top)))
-             (recur (next pre) externs' top))))))))
+                 (when-let [super (:super info')]
+                   (extern-var-info (into [super] (next pre)) externs top nil)))
+             (recur (next pre) externs' top info'))))))))
+
+(defn has-extern?*
+  [pre externs]
+  (boolean (extern-var-info pre externs)))
 
 (defn has-extern?
   ([pre]
@@ -3569,6 +3573,7 @@
             {:warn-type :target :form form :property prop}))
         ;; Unresolveable property on existing extern
         (let [[pre' pre] ((juxt butlast identity) (-> tag meta :prefix))]
+          (println ">>>>>" pre' pre)
           (when (and (has-extern? pre') (not (has-extern? pre)))
             (warning :infer-warning env
               {:warn-type :property :form form

src/test/clojure/cljs/externs_infer_tests.clj

@@ -35,6 +35,25 @@
     (is (true? (ana/has-extern? '[baz] externs)))
     (is (false? (ana/has-extern? '[Baz] externs)))))
 
+(comment
+
+  (def externs
+    (externs/externs-map
+      (closure/load-externs
+        {:externs                 ["src/test/externs/test.js"]
+         :use-only-custom-externs true})))
+
+  ;; working
+  (externs/info externs '[baz])
+  (externs/info externs '[Foo gozMethod])
+
+  (ana/extern-var-info '[baz] externs)
+  (ana/extern-var-info '[Foo gozMethod] externs)
+
+  (ana/has-extern? '[Foo] externs)
+
+  )
+
 (deftest test-has-extern?-defaults
   (let [externs (externs/externs-map)]
     (is (true? (ana/has-extern? '[console] externs)))
@@ -189,6 +208,12 @@
           (string/starts-with?
             "Cannot resolve property gozMethod for inferred type js/Foo")))))
 
+(comment
+
+  (clojure.test/test-vars [#'test-type-hint-infer-unknown-method])
+
+  )
+
 (deftest test-infer-unknown-method-from-externs
   (let [ws  (atom [])
         res (infer-test-helper