Revert setting :jvm-opts in project.clj

tmarble · tmarble · commit 8a232683bcf5 · 2017-11-21T07:38:34.000-06:00
Setting :jvm-opts in project.clj is dangerous because it assumes that said options will work for all users and platforms (which may have wildly differerent resources). Instead user/platform specific options can be set with the JVM_OPTS environment variable: https://github.com/technomancy/leiningen/blob/1a366b2c01054ffcc9a32b104818bc7d1f0024c0/doc/TUTORIAL.md#setting-jvm-options Signed-off-by: Tom Marble <tmarble@info9.net>
diff --git a/project.clj b/project.clj
@@ -48,7 +48,9 @@
              ]
             [lein-environ "1.1.0"]]
 
-  :jvm-opts ["--add-modules" "java.xml.bind"]
+  ;; do NOT modify JVM options here.. instead set the JVM_OPTS env var
+  ;; FFI https://github.com/technomancy/leiningen/blob/1a366b2c01054ffcc9a32b104818bc7d1f0024c0/doc/TUTORIAL.md#setting-jvm-options
+  ;; :jvm-opts ["--add-modules" "java.xml.bind"]
 
   :hooks [leiningen.cljsbuild]
 

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,9 @@`
`48`	`48`	`]`
`49`	`49`	`[lein-environ "1.1.0"]]`
`50`	`50`
`51`		`- :jvm-opts ["--add-modules" "java.xml.bind"]`
	`51`	`+ ;; do NOT modify JVM options here.. instead set the JVM_OPTS env var`
	`52`	`+ ;; FFI https://github.com/technomancy/leiningen/blob/1a366b2c01054ffcc9a32b104818bc7d1f0024c0/doc/TUTORIAL.md#setting-jvm-options`
	`53`	`+ ;; :jvm-opts ["--add-modules" "java.xml.bind"]`
`52`	`54`
`53`	`55`	`:hooks [leiningen.cljsbuild]`
`54`	`56`