Merge pull request #37 from cloudblue/fix_tempdir_windows

Fix tempfile errors on win

Author: marcserrat

connect/reports/renderers/base.py

@@ -1,15 +1,27 @@
 #  Copyright © 2021 CloudBlue. All rights reserved.
-
-from abc import ABCMeta, abstractmethod
-import zipfile
+import contextlib
+import json
 import os
-from datetime import datetime
+import shutil
 import tempfile
-import json
+import zipfile
+from abc import ABCMeta, abstractmethod
+from datetime import datetime
 
 import pytz
 
 
+@contextlib.contextmanager
+def temp_dir():
+    name = tempfile.mkdtemp()
+    yield name
+    try:
+        if os.path.isdir(name):
+            shutil.rmtree(name)
+    except Exception:
+        pass
+
+
 class BaseRenderer(metaclass=ABCMeta):
     """
     Base renderer class with minimum required functionality
@@ -73,7 +85,7 @@ def render(self, data, output_file, start_time=None):
         :type start_time: datetime
         """
         start_time = start_time or datetime.now(tz=pytz.utc)
-        with tempfile.TemporaryDirectory() as tmpdir:
+        with temp_dir() as tmpdir:
             report_file = self.generate_report(data, f'{tmpdir}/report')
             summary_file = self.generate_summary(f'{tmpdir}/summary', start_time)
             pack_file = self.pack_files(report_file, summary_file, output_file)

connect/reports/renderers/pdf.py

@@ -1,14 +1,14 @@
 #  Copyright © 2021 CloudBlue. All rights reserved.
 
 import os
-import tempfile
 from datetime import datetime
 from functools import partial
 
 import pytz
 
 from weasyprint import CSS, HTML, default_url_fetcher
 
+from connect.reports.renderers.base import temp_dir
 from connect.reports.renderers.j2 import Jinja2Renderer
 from connect.reports.renderers.registry import register
 
@@ -38,7 +38,7 @@ class PDFRenderer(Jinja2Renderer):
     """
     def render(self, data, output_file, start_time=None):
         start_time = start_time or datetime.now(tz=pytz.utc)
-        with tempfile.TemporaryDirectory() as tmpdir:
+        with temp_dir() as tmpdir:
             self.cwd = tmpdir
             report_file = self.generate_report(data, f'{tmpdir}/report')
             summary_file = self.generate_summary(f'{tmpdir}/summary', start_time)