Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK](ui): Harmonise event handler return values #722

Open
Tracked by #570
franzheidl opened this issue Jan 16, 2025 · 0 comments
Open
Tracked by #570

[TASK](ui): Harmonise event handler return values #722

franzheidl opened this issue Jan 16, 2025 · 0 comments
Labels
ui-components All tasks related to juno-ui-components library

Comments

@franzheidl
Copy link
Contributor

franzheidl commented Jan 16, 2025

We have inconsistencies in the return values of various handlers. Some return the event, some a value, some synthetic objects fo multiple values. These are historically grown, and in some cases just forwarded from what a third party lib returns. We should assess the current situation, decide whether there is a single approach we want to follow, or if (and why and in what cases) we allow inconsistencies. We should aim at being predictable and practical for our users.

In order to address the problem, we should do the following:

  1. Collect and document the current return values of all components that accept handlers
  2. Assess the collection and come up with a recommendation how to harmonise these
  3. Implement harmonised event handler return values
@franzheidl franzheidl changed the title We have inconsistencies in the return values of various handlers. Some return the event, some a value, some synthetic objects fo multiple values. These are historically grown, and in some cases just forwarded from what a third party lib returns. We should assess the current situation, decide whether there is a single approach we want to follow, or if (and why and in what cases) we allow incosnistencies. We should aim at being predictable asnd practical for our users. Harmonise event handler return values Jan 16, 2025
@franzheidl franzheidl changed the title Harmonise event handler return values [TASK](ui): Harmonise event handler return values Jan 16, 2025
@franzheidl franzheidl added the ui-components All tasks related to juno-ui-components library label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-components All tasks related to juno-ui-components library
Projects
None yet
Development

No branches or pull requests

1 participant