Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC](supernova): Eliminate all ts-ignores, any's and lint errors after TS migration #762

Open
2 of 10 tasks
barsukov opened this issue Feb 10, 2025 · 1 comment
Open
2 of 10 tasks
Assignees
Labels
enhancement New feature or request supernova All tasks related to supernova

Comments

@barsukov
Copy link
Contributor

barsukov commented Feb 10, 2025

Description

After supernova migration, we need to fix all TS-ignores, anies and other ts-expect errors in our code.

Objectives

We group our domain and errors on this lvl:

  • Filters
  • Regions
  • Hooks
  • Libs
  • Slices
  • Lint rules

Acceptance Criteria

Define the criteria that must be met for this epic to be considered complete.

  • No ts-ignore in supernova
  • No ts-expect in supernova
  • Only any when really needed.

Tasks

Break down the epic into smaller, actionable tasks or user stories. Bigger tasks should be issues themselves.

@barsukov barsukov added enhancement New feature or request supernova All tasks related to supernova labels Feb 10, 2025
@barsukov
Copy link
Contributor Author

Just post it for now
will transfer in a proper description later:

src/components/alerts/AlertStatus.tsx:34
1 src/components/alerts/shared/AlertDescription.tsx:7
5 src/components/alerts/shared/AlertLabels.tsx:22
1 src/components/alerts/shared/AlertSilencesList.tsx:33
1 src/components/CustomAppShell.tsx:16

 7  src/components/filters/FilterPills.tsx:15
11  src/components/filters/FilterSelect.tsx:24
 2  src/components/filters/PredefinedFilters.tsx:14

 3  src/components/regions/Region.tsx:37
 3  src/components/regions/RegionsList.tsx:25

 8  src/components/silences/CreateSilence.tsx:39
 6  src/components/silences/ExpireSilence.tsx:13
 4  src/components/silences/RecreateSilence.tsx:121
 1  src/components/silences/silenceHelpers.ts:46
25  src/components/silences/SilenceScheduled.tsx:7
 6  src/components/silences/SilencesList.tsx:41

 4  src/components/StoreProvider.tsx:7
 1  src/helpers.ts:9

 1  src/hooks/useBoundMutation.ts:2
 1  src/hooks/useBoundQuery.ts:6
 7  src/hooks/useUrlQueryState/index.ts:15
 2  src/hooks/useUrlQueryState/utils.ts:16
12  src/hooks/useUrlState.ts:40

 1  src/index.ts:11

 3  src/lib/createAlertsSlice.test.tsx:7
 5  src/lib/createAlertsSlice.tsx:6
 2  src/lib/createFiltersSlice.test.tsx:7
 3  src/lib/createFiltersSlice.tsx:6
13  src/lib/createSilencesSlice.test.tsx:7
 3  src/lib/createSilencesSlice.tsx:147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request supernova All tasks related to supernova
Projects
None yet
Development

No branches or pull requests

2 participants