-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow attachment of managed amplify admin policy #32
Conversation
/terratest |
/terratest |
💥 This pull request now has conflicts. Could you fix it @kevcube? 🙏 |
This PR was closed due to inactivity and merge conflicts. 😭 |
💥 This pull request now has conflicts. Could you fix it @kevcube? 🙏 |
/terratest |
/terratest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevcube I think if would be better to have variable managed_policy_arns
as list of policy arns to attach instead of bool variable that attaches only one hardcoded policy
I agree with @goruha |
💥 This pull request now has conflicts. Could you fix it @kevcube? 🙏 |
This PR was closed due to inactivity and merge conflicts. 😭 |
what
AWS provides a managed policy for AWS Amplify roles
This PR gives a boolean flag to allow users to attach this policy
why
It's a prewritten, AWS-approved policy. Useful to Amplify users.
references
https://us-east-1.console.aws.amazon.com/iam/home?region=us-east-1#/policies/details/arn%3Aaws%3Aiam%3A%3Aaws%3Apolicy%2FAdministratorAccess-Amplify