Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow attachment of managed amplify admin policy #32

Closed
wants to merge 8 commits into from

Conversation

kevcube
Copy link
Contributor

@kevcube kevcube commented Apr 29, 2024

what

AWS provides a managed policy for AWS Amplify roles
This PR gives a boolean flag to allow users to attach this policy

why

It's a prewritten, AWS-approved policy. Useful to Amplify users.

references

https://us-east-1.console.aws.amazon.com/iam/home?region=us-east-1#/policies/details/arn%3Aaws%3Aiam%3A%3Aaws%3Apolicy%2FAdministratorAccess-Amplify

@kevcube kevcube requested review from a team as code owners April 29, 2024 15:51
@mergify mergify bot added the triage Needs triage label Apr 29, 2024
@kevcube kevcube added minor New features that do not break anything feature New functionality and removed triage Needs triage labels Apr 30, 2024
@kevcube
Copy link
Contributor Author

kevcube commented Apr 30, 2024

/terratest

@goruha
Copy link
Member

goruha commented Jun 21, 2024

/terratest

Copy link

mergify bot commented Jul 15, 2024

💥 This pull request now has conflicts. Could you fix it @kevcube? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Jul 15, 2024
@mergify mergify bot closed this Jul 15, 2024
Copy link

mergify bot commented Jul 15, 2024

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot removed the conflict This PR has conflicts label Jul 15, 2024
@kevcube kevcube reopened this Jul 15, 2024
Copy link

mergify bot commented Jul 15, 2024

💥 This pull request now has conflicts. Could you fix it @kevcube? 🙏

@mergify mergify bot added conflict This PR has conflicts and removed conflict This PR has conflicts labels Jul 15, 2024
@osterman
Copy link
Member

/terratest

@kevcube
Copy link
Contributor Author

kevcube commented Jul 22, 2024

/terratest

Copy link
Member

@goruha goruha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevcube I think if would be better to have variable managed_policy_arns as list of policy arns to attach instead of bool variable that attaches only one hardcoded policy

@osterman
Copy link
Member

I agree with @goruha

Copy link

mergify bot commented Sep 19, 2024

💥 This pull request now has conflicts. Could you fix it @kevcube? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Sep 19, 2024
@mergify mergify bot closed this Sep 19, 2024
Copy link

mergify bot commented Sep 19, 2024

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot removed the conflict This PR has conflicts label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants