From deb8ce1a3c99444a86e361d87ad3280f93674038 Mon Sep 17 00:00:00 2001 From: Joan Perals Date: Wed, 15 Jan 2025 16:03:27 +0100 Subject: [PATCH] fix: Allow text selection in date picker and date range picker (#3181) --- src/date-picker/index.tsx | 6 ------ src/date-range-picker/styles.scss | 2 -- src/internal/components/dropdown/styles.scss | 1 - src/internal/components/options-list/styles.scss | 1 + 4 files changed, 1 insertion(+), 9 deletions(-) diff --git a/src/date-picker/index.tsx b/src/date-picker/index.tsx index 01a1ac5fd9..843a9a2683 100644 --- a/src/date-picker/index.tsx +++ b/src/date-picker/index.tsx @@ -168,11 +168,6 @@ const DatePicker = React.forwardRef( baseProps.className = clsx(baseProps.className, styles.root, styles['date-picker-container']); - const handleMouseDown = (event: React.MouseEvent) => { - // prevent currently focused element from losing it - event.preventDefault(); - }; - return (
{disabled || readOnly ? ( @@ -183,7 +178,6 @@ const DatePicker = React.forwardRef( stretchHeight={true} open={isDropDownOpen} onDropdownClose={onDropdownCloseHandler} - onMouseDown={handleMouseDown} trigger={trigger} expandToViewport={expandToViewport} scrollable={false} diff --git a/src/date-range-picker/styles.scss b/src/date-range-picker/styles.scss index ede08070f4..e0d13f0a13 100644 --- a/src/date-range-picker/styles.scss +++ b/src/date-range-picker/styles.scss @@ -131,7 +131,6 @@ $calendar-header-color: awsui.$color-text-body-default; } .label { - user-select: text; cursor: default; } @@ -173,7 +172,6 @@ $calendar-header-color: awsui.$color-text-body-default; } .dropdown-content { - user-select: text; background-color: awsui.$color-background-container-content; inline-size: calc(2 * #{$calendar-grid-width} + #{awsui.$space-xs} + 2 * #{awsui.$space-l}); diff --git a/src/internal/components/dropdown/styles.scss b/src/internal/components/dropdown/styles.scss index a96091db1c..f7d9eeb51f 100644 --- a/src/internal/components/dropdown/styles.scss +++ b/src/internal/components/dropdown/styles.scss @@ -23,7 +23,6 @@ display: none; // Needs to be higher than a global navigation element z-index: 2000; - user-select: none; transform-origin: top; // When used in portal we need z-index to be higher than modal's diff --git a/src/internal/components/options-list/styles.scss b/src/internal/components/options-list/styles.scss index 5b0adff134..7ea6130815 100644 --- a/src/internal/components/options-list/styles.scss +++ b/src/internal/components/options-list/styles.scss @@ -23,6 +23,7 @@ border-start-end-radius: awsui.$border-radius-dropdown; border-end-start-radius: awsui.$border-radius-dropdown; border-end-end-radius: awsui.$border-radius-dropdown; + user-select: none; &-embedded { border-start-start-radius: 0px;