fix: Remove aria-expanded from date range picker trigger (#3259)

cloudscape-design · Feb 6, 2025 · e8274c3 · e8274c3
1 parent 5779bdd
commit e8274c3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/date-range-picker/__tests__/date-range-picker.test.tsx b/src/date-range-picker/__tests__/date-range-picker.test.tsx
@@ -176,6 +176,13 @@ describe('Date range picker', () => {
           i18nStrings.modeSelectionLabel
         );
       });
+
+      test('does not have aria-expanded', () => {
+        const { wrapper } = renderDateRangePicker();
+        expect(wrapper.findTrigger().getElement()).not.toHaveAttribute('aria-expanded');
+        wrapper.openDropdown();
+        expect(wrapper.findDropdown()!.getElement()).not.toHaveAttribute('aria-expanded');
+      });
     });
 
     test('opens relative range mode by default', () => {

diff --git a/src/internal/components/button-trigger/index.tsx b/src/internal/components/button-trigger/index.tsx
@@ -40,7 +40,7 @@ export interface ButtonTriggerProps extends BaseComponentProps {
 const ButtonTrigger = (
   {
     children,
-    pressed = false,
+    pressed,
     hideCaret = false,
     disabled = false,
     readOnly = false,

diff --git a/src/select/parts/trigger.tsx b/src/select/parts/trigger.tsx
@@ -112,7 +112,7 @@ const Trigger = React.forwardRef(
         {...triggerProps}
         id={id}
         ref={mergedRef}
-        pressed={isOpen}
+        pressed={!!isOpen}
         disabled={disabled}
         readOnly={readOnly}
         invalid={invalid}