Skip to content

Commit e8274c3

Browse files
authored
fix: Remove aria-expanded from date range picker trigger (#3259)
1 parent 5779bdd commit e8274c3

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

src/date-range-picker/__tests__/date-range-picker.test.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,13 @@ describe('Date range picker', () => {
176176
i18nStrings.modeSelectionLabel
177177
);
178178
});
179+
180+
test('does not have aria-expanded', () => {
181+
const { wrapper } = renderDateRangePicker();
182+
expect(wrapper.findTrigger().getElement()).not.toHaveAttribute('aria-expanded');
183+
wrapper.openDropdown();
184+
expect(wrapper.findDropdown()!.getElement()).not.toHaveAttribute('aria-expanded');
185+
});
179186
});
180187

181188
test('opens relative range mode by default', () => {

src/internal/components/button-trigger/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export interface ButtonTriggerProps extends BaseComponentProps {
4040
const ButtonTrigger = (
4141
{
4242
children,
43-
pressed = false,
43+
pressed,
4444
hideCaret = false,
4545
disabled = false,
4646
readOnly = false,

src/select/parts/trigger.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ const Trigger = React.forwardRef(
112112
{...triggerProps}
113113
id={id}
114114
ref={mergedRef}
115-
pressed={isOpen}
115+
pressed={!!isOpen}
116116
disabled={disabled}
117117
readOnly={readOnly}
118118
invalid={invalid}

0 commit comments

Comments
 (0)