Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: TopNavigation bottom border #3230

Open
2 tasks done
purplepenguin2 opened this issue Jan 28, 2025 · 1 comment
Open
2 tasks done

[Feature Request]: TopNavigation bottom border #3230

purplepenguin2 opened this issue Jan 28, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@purplepenguin2
Copy link

Description

There was a PR a little bit ago to add the missing bottom border to the TopNavigation component, but it looks like the commit was then reverted, and the revert was reverted? The current state appears the change is not part of master. Is there a reason this was reverted? It'd be really nice to have, so we don't need to manually add the bottom border when using the component.

Initial commit: 13ff9d4
Revert: Gone / seemingly merged somehow with the reverted revert.
Reverted revert: c357e20

Code of Conduct
@purplepenguin2 purplepenguin2 added the enhancement New feature or request label Jan 28, 2025
@cansuaa
Copy link
Contributor

cansuaa commented Feb 12, 2025

Hi, we have reverted it after deciding to discuss it further within the team. I don't have a date yet when it'll be released but it is in our radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cansuaa @purplepenguin2