Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#515): codegen and default problem #525

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix(#515): codegen and default problem #525

merged 1 commit into from
Nov 6, 2024

Conversation

PureWhiteWu
Copy link
Member

@PureWhiteWu PureWhiteWu added A-volo-build This issue concerns the `volo-build` crate. A-volo-thrift The issue concerns the `volo-thrift` crate. C-bug This is a bug-report. Bug-fix PRs use `C-enhancement` instead. labels Nov 6, 2024
@PureWhiteWu PureWhiteWu self-assigned this Nov 6, 2024
@PureWhiteWu PureWhiteWu requested review from a team as code owners November 6, 2024 13:34
@PureWhiteWu PureWhiteWu merged commit 5d85c3d into main Nov 6, 2024
13 of 14 checks passed
@PureWhiteWu PureWhiteWu deleted the fix/issue_515 branch November 6, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ggiggle Ggiggle Ggiggle approved these changes

Assignees

@PureWhiteWu PureWhiteWu

Labels
A-volo-build This issue concerns the `volo-build` crate. A-volo-thrift The issue concerns the `volo-thrift` crate. C-bug This is a bug-report. Bug-fix PRs use `C-enhancement` instead.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thrift bool parameter gets into unknown volo_genbool type, methods started with '_' losts underscore symbol
2 participants
@PureWhiteWu @Ggiggle