Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'none' tag for project with 'rust-toolchain' file #55

Open
DCjanus opened this issue May 28, 2019 · 2 comments
Open

'none' tag for project with 'rust-toolchain' file #55

DCjanus opened this issue May 28, 2019 · 2 comments

Comments

@DCjanus
Copy link

DCjanus commented May 28, 2019

There are some project put rust-toolchain file in root directory, for example: nightly-2019-05-22.

With those project, no matter which tag I choose, I have to info: syncing channel updates for 'nightly-2019-05-22-x86_64-unknown-linux-gnu' when I build the docker image, even I chosed clux/muslrust:nightly-2019-05-22(because this image installed nightly channel toolchain rather than nightly-2019-05-22).

If I have to download toolchain, maybe image without pre-installed toolchain is better?

The way to install rustup without pre-installed toolchain is:

curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain none
@DCjanus DCjanus changed the title 'no-toolchain' tag for project with 'rust-toolchain' file 'none' tag for project with 'rust-toolchain' file May 28, 2019
@clux
Copy link
Owner

clux commented May 28, 2019

There has to be a default toolchain installed for builds to work in most places though, and the image is purposefully built with the entire toolchain. Downloading another update inside this image is counterproductive (you'd just download another image instead).

Maybe if we installed with the explicit nightly we expect to be available?

e.g. something like --default-toolchain nightly-$(date +"%Y-%m-%d")

@DCjanus
Copy link
Author

DCjanus commented May 28, 2019

That sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants