Run go-makefile-maker

Author: sapcc-bot

.dockerignore

@@ -7,13 +7,10 @@
 # TODO: uncomment when applications no longer use git to get version information
 #.git/
 /.github/
-/.gitignore
-/.golangci.yaml
 /.goreleaser.yml
 /.vscode/
 /CONTRIBUTING.md
 /Dockerfile
-/LICENSE*
 /Makefile.maker.yaml
 /README.md
 /build/

.github/workflows/checks.yaml

@@ -31,7 +31,7 @@ jobs:
           check-latest: true
           go-version: 1.25.4
       - name: Run golangci-lint
-        uses: golangci/golangci-lint-action@v8
+        uses: golangci/golangci-lint-action@v9
         with:
           version: latest
       - name: Delete pre-installed shellcheck

.golangci.yaml

@@ -145,6 +145,10 @@ linters:
       enable-all: true
     nolintlint:
       require-specific: true
+    modernize:
+      disable:
+        # omitzero requires removing omitempty tags in kubernetes api struct types which are nested, which is intepreted by controller-gen and breaks the CRDs.
+        - omitzero
     perfsprint:
       # modernize generates nicer fix code
       concat-loop: false

Dockerfile

@@ -11,6 +11,39 @@ RUN make -C /src install PREFIX=/pkg GOTOOLCHAIN=local
 
 ################################################################################
 
+# To only build the tests run: docker build . --target test
+# We can't do `FROM builder AS test` here, as then make prepare-static-check would not be cached during interactive use when developing
+# and caching all the tools, especially golangci-lint, takes a few minutes.
+FROM golang:1.25.4-alpine3.22 AS test
+
+COPY Makefile /src/Makefile
+
+# used below by USER
+RUN addgroup -g 4200 appgroup \
+  && adduser -h /home/appuser -s /sbin/nologin -G appgroup -D -u 4200 appuser
+
+RUN apk add --no-cache --no-progress git make py3-pip \
+  && pip3 install --break-system-packages reuse \
+  && make -C /src prepare-static-check
+
+
+# We only copy here because we want the "prepare-static-check" to be cacheable.
+# It is not a problem that we are overwriting the go cache from the earlier steps because we do not need to rebuild those tools.
+COPY --from=builder /go /go
+COPY --from=builder /src /src
+
+RUN make -C /src static-check
+
+# Some things like postgres do not like to run as root. For simplicity, just always run as an unprivileged user,
+# but for it to be able to read the go cache, we need to allow it.
+RUN chown -R 4200:4200 /src/ /go/
+USER 4200:4200
+RUN cd /src \
+  && git config --global --add safe.directory /src \
+  && make build/cover.out
+
+################################################################################
+
 FROM alpine:3.22
 
 # upgrade all installed packages to fix potential CVEs in advance