Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation, release process, and improve testing #18

Open
11 tasks
lgo opened this issue Nov 18, 2017 · 1 comment
Open
11 tasks

Add documentation, release process, and improve testing #18

lgo opened this issue Nov 18, 2017 · 1 comment

Comments

@lgo
Copy link
Contributor

lgo commented Nov 18, 2017

Lumping this all together as these are all improvements that just come with better support for the adapter.

  • Create a proper release process
    • Releasing to rubygems. (Look into using TravisCI to automatically publish tags)
    • Changelog
    • Tagging
    • Make sure to support Activerecord 4.x (our 1.x) and 5.x (our 2.x) 👏. This could either be using two different branches, or supporting them from the same branch (sort of like Py2 vs Py3 support).
  • Add documentation (and changelog)
  • Improve testing
    • Possibly pull in existing ActiveRecord PostgreSQL tests. Again, we'll have to do this separately for the different ActiveRecord versions likely.
  • Add rake tasks to manage the database
  • Add custom CockroachDB capabilities
    • Don't use PostgreSQL types, but use cockroach types. We'll then alias PostgreSQL ones to their respective CockroachDB one
@lgo
Copy link
Contributor Author

lgo commented Nov 20, 2017

I'm currently working on getting the tests working and there are two possible approaches:

  1. Duplicating the PostgreSQL tests in the main ActiveRecord repo to run tests from there (on this fork)
  2. Getting those same tests to work from this repository instead, so we don't need a modified ActiveRecord. (Experimenting on this branch)

Approach 2 is a lot more ideal as it will be easier to have AR4 and AR5 tests and keep everything in this repo. We'll just need a way to leverage test helpers from outside the ActiveRecord gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant