From da08d5186da39864e25c1f8f37aaed51d8cd6ead Mon Sep 17 00:00:00 2001 From: Rich Loveland Date: Wed, 12 Mar 2025 15:41:09 -0400 Subject: [PATCH 1/2] Add note to clarify column-level encryption timing Clarify that performance timings in column-level-encryption.md refer to 10k operations, not single operations. Takes over from cockroachdb/docs#18074 --- src/current/v23.2/column-level-encryption.md | 2 +- src/current/v24.1/column-level-encryption.md | 2 +- src/current/v24.2/column-level-encryption.md | 2 +- src/current/v24.3/column-level-encryption.md | 2 +- src/current/v25.1/column-level-encryption.md | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/current/v23.2/column-level-encryption.md b/src/current/v23.2/column-level-encryption.md index 9f4193fac2b..e0b1a4242e4 100644 --- a/src/current/v23.2/column-level-encryption.md +++ b/src/current/v23.2/column-level-encryption.md @@ -92,7 +92,7 @@ Use of the `encrypt` built-in function can have anywhere from 10-40% overhead de Cockroach Labs measured baseline performance in a 3-node CockroachDB cluster running on three [`n1-standard-4` machines on GCP](https://cloud.google.com/compute/docs/general-purpose-machines#n1_machines). -Without using `encrypt` or `decrypt`, the following statement generally ran in 60-80 ms: +Without using `encrypt` or `decrypt`, the following statement generally ran in 60-80 ms (note: in this and the following examples, the timings we report are for 10,000 operations): {% include_cached copy-clipboard.html %} ~~~ sql diff --git a/src/current/v24.1/column-level-encryption.md b/src/current/v24.1/column-level-encryption.md index 8631ba80a69..5436a9b3c74 100644 --- a/src/current/v24.1/column-level-encryption.md +++ b/src/current/v24.1/column-level-encryption.md @@ -92,7 +92,7 @@ Use of the `encrypt` built-in function can have anywhere from 10-40% overhead de Cockroach Labs measured baseline performance in a 3-node CockroachDB cluster running on three [`n1-standard-4` machines on GCP](https://cloud.google.com/compute/docs/general-purpose-machines#n1_machines). -Without using `encrypt` or `decrypt`, the following statement generally ran in 60-80 ms: +Without using `encrypt` or `decrypt`, the following statement generally ran in 60-80 ms (note: in this and the following examples, the timings we report are for 10,000 operations): {% include_cached copy-clipboard.html %} ~~~ sql diff --git a/src/current/v24.2/column-level-encryption.md b/src/current/v24.2/column-level-encryption.md index 8631ba80a69..5436a9b3c74 100644 --- a/src/current/v24.2/column-level-encryption.md +++ b/src/current/v24.2/column-level-encryption.md @@ -92,7 +92,7 @@ Use of the `encrypt` built-in function can have anywhere from 10-40% overhead de Cockroach Labs measured baseline performance in a 3-node CockroachDB cluster running on three [`n1-standard-4` machines on GCP](https://cloud.google.com/compute/docs/general-purpose-machines#n1_machines). -Without using `encrypt` or `decrypt`, the following statement generally ran in 60-80 ms: +Without using `encrypt` or `decrypt`, the following statement generally ran in 60-80 ms (note: in this and the following examples, the timings we report are for 10,000 operations): {% include_cached copy-clipboard.html %} ~~~ sql diff --git a/src/current/v24.3/column-level-encryption.md b/src/current/v24.3/column-level-encryption.md index 8631ba80a69..5436a9b3c74 100644 --- a/src/current/v24.3/column-level-encryption.md +++ b/src/current/v24.3/column-level-encryption.md @@ -92,7 +92,7 @@ Use of the `encrypt` built-in function can have anywhere from 10-40% overhead de Cockroach Labs measured baseline performance in a 3-node CockroachDB cluster running on three [`n1-standard-4` machines on GCP](https://cloud.google.com/compute/docs/general-purpose-machines#n1_machines). -Without using `encrypt` or `decrypt`, the following statement generally ran in 60-80 ms: +Without using `encrypt` or `decrypt`, the following statement generally ran in 60-80 ms (note: in this and the following examples, the timings we report are for 10,000 operations): {% include_cached copy-clipboard.html %} ~~~ sql diff --git a/src/current/v25.1/column-level-encryption.md b/src/current/v25.1/column-level-encryption.md index 8631ba80a69..5436a9b3c74 100644 --- a/src/current/v25.1/column-level-encryption.md +++ b/src/current/v25.1/column-level-encryption.md @@ -92,7 +92,7 @@ Use of the `encrypt` built-in function can have anywhere from 10-40% overhead de Cockroach Labs measured baseline performance in a 3-node CockroachDB cluster running on three [`n1-standard-4` machines on GCP](https://cloud.google.com/compute/docs/general-purpose-machines#n1_machines). -Without using `encrypt` or `decrypt`, the following statement generally ran in 60-80 ms: +Without using `encrypt` or `decrypt`, the following statement generally ran in 60-80 ms (note: in this and the following examples, the timings we report are for 10,000 operations): {% include_cached copy-clipboard.html %} ~~~ sql From f397d11c185a4295c1df945ebf4458f8e0aaec6e Mon Sep 17 00:00:00 2001 From: Rich Loveland Date: Thu, 3 Apr 2025 14:02:42 -0400 Subject: [PATCH 2/2] Update with taroface feedback (1) --- src/current/v23.2/column-level-encryption.md | 2 +- src/current/v24.1/column-level-encryption.md | 2 +- src/current/v24.2/column-level-encryption.md | 2 +- src/current/v24.3/column-level-encryption.md | 2 +- src/current/v25.1/column-level-encryption.md | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/current/v23.2/column-level-encryption.md b/src/current/v23.2/column-level-encryption.md index e0b1a4242e4..99cb41b5c86 100644 --- a/src/current/v23.2/column-level-encryption.md +++ b/src/current/v23.2/column-level-encryption.md @@ -92,7 +92,7 @@ Use of the `encrypt` built-in function can have anywhere from 10-40% overhead de Cockroach Labs measured baseline performance in a 3-node CockroachDB cluster running on three [`n1-standard-4` machines on GCP](https://cloud.google.com/compute/docs/general-purpose-machines#n1_machines). -Without using `encrypt` or `decrypt`, the following statement generally ran in 60-80 ms (note: in this and the following examples, the timings we report are for 10,000 operations): +Without using `encrypt` or `decrypt`, the following statement (which represents 10,000 operations) generally ran in 60-80 ms: {% include_cached copy-clipboard.html %} ~~~ sql diff --git a/src/current/v24.1/column-level-encryption.md b/src/current/v24.1/column-level-encryption.md index 5436a9b3c74..36ca8a8a227 100644 --- a/src/current/v24.1/column-level-encryption.md +++ b/src/current/v24.1/column-level-encryption.md @@ -92,7 +92,7 @@ Use of the `encrypt` built-in function can have anywhere from 10-40% overhead de Cockroach Labs measured baseline performance in a 3-node CockroachDB cluster running on three [`n1-standard-4` machines on GCP](https://cloud.google.com/compute/docs/general-purpose-machines#n1_machines). -Without using `encrypt` or `decrypt`, the following statement generally ran in 60-80 ms (note: in this and the following examples, the timings we report are for 10,000 operations): +Without using `encrypt` or `decrypt`, the following statement (which represents 10,000 operations) generally ran in 60-80 ms: {% include_cached copy-clipboard.html %} ~~~ sql diff --git a/src/current/v24.2/column-level-encryption.md b/src/current/v24.2/column-level-encryption.md index 5436a9b3c74..36ca8a8a227 100644 --- a/src/current/v24.2/column-level-encryption.md +++ b/src/current/v24.2/column-level-encryption.md @@ -92,7 +92,7 @@ Use of the `encrypt` built-in function can have anywhere from 10-40% overhead de Cockroach Labs measured baseline performance in a 3-node CockroachDB cluster running on three [`n1-standard-4` machines on GCP](https://cloud.google.com/compute/docs/general-purpose-machines#n1_machines). -Without using `encrypt` or `decrypt`, the following statement generally ran in 60-80 ms (note: in this and the following examples, the timings we report are for 10,000 operations): +Without using `encrypt` or `decrypt`, the following statement (which represents 10,000 operations) generally ran in 60-80 ms: {% include_cached copy-clipboard.html %} ~~~ sql diff --git a/src/current/v24.3/column-level-encryption.md b/src/current/v24.3/column-level-encryption.md index 5436a9b3c74..36ca8a8a227 100644 --- a/src/current/v24.3/column-level-encryption.md +++ b/src/current/v24.3/column-level-encryption.md @@ -92,7 +92,7 @@ Use of the `encrypt` built-in function can have anywhere from 10-40% overhead de Cockroach Labs measured baseline performance in a 3-node CockroachDB cluster running on three [`n1-standard-4` machines on GCP](https://cloud.google.com/compute/docs/general-purpose-machines#n1_machines). -Without using `encrypt` or `decrypt`, the following statement generally ran in 60-80 ms (note: in this and the following examples, the timings we report are for 10,000 operations): +Without using `encrypt` or `decrypt`, the following statement (which represents 10,000 operations) generally ran in 60-80 ms: {% include_cached copy-clipboard.html %} ~~~ sql diff --git a/src/current/v25.1/column-level-encryption.md b/src/current/v25.1/column-level-encryption.md index 5436a9b3c74..36ca8a8a227 100644 --- a/src/current/v25.1/column-level-encryption.md +++ b/src/current/v25.1/column-level-encryption.md @@ -92,7 +92,7 @@ Use of the `encrypt` built-in function can have anywhere from 10-40% overhead de Cockroach Labs measured baseline performance in a 3-node CockroachDB cluster running on three [`n1-standard-4` machines on GCP](https://cloud.google.com/compute/docs/general-purpose-machines#n1_machines). -Without using `encrypt` or `decrypt`, the following statement generally ran in 60-80 ms (note: in this and the following examples, the timings we report are for 10,000 operations): +Without using `encrypt` or `decrypt`, the following statement (which represents 10,000 operations) generally ran in 60-80 ms: {% include_cached copy-clipboard.html %} ~~~ sql