-
-
Notifications
You must be signed in to change notification settings - Fork 771
#581 Buffer Full Video. Preload whole videos. (issue: fail for biggest videos by browser defaults) #3241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
hi and thanks! @Abhyshekbhalaji You didn't add a toggle to our settings.need to add a toggle |
|
Yes @ImprovedTube will have a look at it, currently the duration is set to 30 seconds for advance buffering if in case the duration is lower it is set to the entire duration for preload , the toggle is something i need to look at |
|
Can you elaborate where you like to have the toggle feature plus the duration? |
|
hi! yes, had read code. is it working effectively? currently it fits below our other performance features |
|
possible somebody new wants to add the missing toggle, still before you or I do: https://github.com/code-charity/youtube/wiki/Contributing#Development to add an input you can mimic our other features with an input Let's name this feature Preload / increase Buffer by x seconds (experimental), or so at first, in en/messages.js, until we confirmed it might works with different Youtube accounts |
|
Hey @ImprovedTube the UI part? Hope someone does it i think i have added the necessary backend part for that! i really dont think we do need a toggle for shorts ( i mean entire duration is preloaded) for long videos the toggle options are now enabled with my new pr |
|
Thanks @Abhyshekbhalaji! Does this work with DASH streaming, or only the legacy type? |
|
Thanks @ImprovedTube and @HaleTom for the feedback! Here's a summary of the current status and what's needed for merge: Current Status: What Still Needs to Be Done: Implementation Plan: The feature is mainly relevant for long videos since shorts already preload their entire duration automatically. Once the UI work (toggle + duration input) and DASH streaming compatibility are confirmed, this PR should be ready for merge. I'm working on these remaining items - happy to have help from the community on the UI portion if anyone wants to contribute! |
|
hi! @HaleTom @Abhyshekbhalaji please indicate LLM parts of code (and messages (if any)) |
Resolves #3240 — Adds an "Advanced Video Buffering" toggle to the extension settings.
This new option allows users to aggressively buffer and preload more of the YouTube video for smoother playback, based on requests from users experiencing slow or interrupted playback.
UI Implementation
How It Works
Testing
Thoroughly tested on various YouTube videos and all works as expected.