-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recording audio too #10
Comments
I agree, someone had started a fork for in app audio. I pulled in the changes and started the It would be great if you could take a look about how both audio streams are implemented on that branch. Feel free to make PR for any tweaks or suggestions. One thing I have not been able to get too is, both in app audio and microphone audio should be options passed in the initial config. |
@code-matt When originally testing that branch, did you experience inconsistency with the microphone recording? The first couple times it worked (recorded the microphone audio successfully), but now it doesn't work (even though the code is unchanged to the best of my knowledge) at all. The symptom is in the Any thoughts on this? BTW, I am testing this on an actual iOS device (ios 12.4) |
@chrisronline I tried earlier and have not run into that issue. I went ahead printed the I am experiencing a different one though, the in app audio being turned down to the point where can barely be heard during the actual period of recording. It's mixed fine with the microphone when playing back after. This seems to be the default behavior of iOS after looking into it though. |
@chrisronline I managed one worse after continuing for a while longer. I can no longer record anything after it working fine for nearly 30 minutes. I do not see errors but when going to play back, always see:
Even after uninstalling the app and restarting the device. Does not matter if I pick screen only or screen and microphone. |
Sorry I'm a little late to the party here, but I've been testing the branch with the audio implementation. It seems to work perfectly within the test app, but when I use it in my own app, it seems to not only corrupt the media files on stop, but I also get an error message in the stopRecording function that completely nukes the app saying "Thread 21: Fatal error: Unexpectedly found nil while implicitly unwrapping an Optional value". |
I have not been able to get anywhere with this, my initial findings were around needing to queue the audio/video writes. Have not been able to get back to it, though. I will leave the audio branch and prepare one for iOS13 without inapp or mic audio until this can be figured out. |
I pushed up a small change that fixed the one big crash for me. Just messing around for a long while with
Making sure this does not get hit more than once seems to have stabilized things. I am no longer getting recordings I can not play back. Could one of you try ? |
@code-matt which commit / branch is this fix on? I am having similar issues on playback but running into {"error":{"domain":"AVFoundationErrorDomain","code":-11829},"target":5175} I've also tried to playback via setting a timeout after recording completes of 10,000 MS with still same result |
OK I tried testapp in XCode 11.2.1 And same issue out of the box on branch record_inapp_audio_merge When calling
|
What are you thoughts on adding (optional) audio recording too? I'd like to record the screen and the mic for my use case. The code looks fairly straight-forward and I got it working locally, but unsure if it should be on my default or perhaps I should publish a fork with the changes instead?
Thanks!
The text was updated successfully, but these errors were encountered: