fix: make all targets pass, title GH actions

John Doe · John Doe · commit 1c8b7194ccc7 · 2025-08-14T03:15:26.000+02:00
diff --git a/.github/workflows/code-pushup-fork.centralized.yml b/.github/workflows/code-pushup-fork.centralized.yml
@@ -1,4 +1,4 @@
-name: Code PushUp (fork)
+name: Code PushUp - Centralized Style (fork)
 
 # separated from code-pushup.yml for security reasons
 # => requires permissions to create PR comment
@@ -20,7 +20,7 @@ permissions:
 jobs:
   code-pushup:
     runs-on: ubuntu-latest
-    name: Code PushUp
+    name: Code PushUp - Centralized Style
     if: github.event.pull_request.head.repo.fork
     steps:
       - name: Checkout repository
@@ -35,4 +35,4 @@ jobs:
       - name: Run Code PushUp action
         uses: code-pushup/github-action@v0
         with:
-          bin: npx nx code-pushup-old --
+          bin: npx nx code-pushup-central --
diff --git a/.github/workflows/code-pushup-fork.monorepo.yml b/.github/workflows/code-pushup-fork.monorepo.yml
@@ -1,4 +1,4 @@
-name: Code PushUp (fork)
+name: Code PushUp - Monorepo Style (fork)
 
 # separated from code-pushup.yml for security reasons
 # => requires permissions to create PR comment
@@ -20,7 +20,7 @@ permissions:
 jobs:
   code-pushup:
     runs-on: ubuntu-latest
-    name: Code PushUp
+    name: Code PushUp - Monorepo Style
     if: github.event.pull_request.head.repo.fork
     steps:
       - name: Checkout PR head
diff --git a/.github/workflows/code-pushup.centralized.yml b/.github/workflows/code-pushup.centralized.yml
@@ -1,4 +1,4 @@
-name: Code PushUp
+name: Code PushUp - Centralized Style
 
 on:
   push:
@@ -15,7 +15,7 @@ permissions:
 jobs:
   code-pushup:
     runs-on: ubuntu-latest
-    name: Code PushUp
+    name: Code PushUp - Centralized Style
     # ignore PRs from forks, handled by code-pushup-fork.yml
     if: ${{ !github.event.pull_request.head.repo.fork }}
     env:
@@ -36,4 +36,4 @@ jobs:
       - name: Run Code PushUp action
         uses: code-pushup/github-action@v0
         with:
-          bin: npx nx code-pushup-old --
+          bin: npx nx code-pushup-central --
diff --git a/.github/workflows/code-pushup.monorepo.yml b/.github/workflows/code-pushup.monorepo.yml
@@ -1,4 +1,4 @@
-name: Code PushUp
+name: Code PushUp - Monorepo Style
 
 on:
   push:
@@ -15,7 +15,7 @@ permissions:
 jobs:
   code-pushup:
     runs-on: ubuntu-latest
-    name: Code PushUp
+    name: Code PushUp - Monorepo Style
     # ignore PRs from forks, handled by code-pushup-fork.yml
     if: ${{ !github.event.pull_request.head.repo.fork }}
     env:
diff --git a/code-pushup.central.config.ts b/code-pushup.central.config.ts
@@ -26,6 +26,7 @@ const merged = mergeConfigs(
   await typescriptPluginConfig({
     tsconfig: 'packages/cli/tsconfig.lib.json',
   }),
+
   await eslintCoreConfigNx(),
   jsDocsCoreConfig([
     'packages/**/src/**/*.ts',
diff --git a/code-pushup.config.ts b/code-pushup.config.ts
@@ -1,14 +1,9 @@
 import 'dotenv/config';
 import {
-  coverageCoreConfigNx,
-  eslintCoreConfigNx,
-  jsDocsCoreConfig,
-  jsDocsExclusionPatterns,
   jsPackagesCoreConfig,
   lighthouseCoreConfig,
   loadEnv,
   mergeConfigs,
-  typescriptPluginConfig,
 } from './code-pushup.preset.js';
 import type { CoreConfig } from './packages/models/src/index.js';
 
@@ -22,16 +17,7 @@ const config: CoreConfig = {
 export default mergeConfigs(
   config,
   await jsPackagesCoreConfig(),
-  await coverageCoreConfigNx(projectName),
   await lighthouseCoreConfig(
     'https://github.com/code-pushup/cli?tab=readme-ov-file#code-pushup-cli/',
   ),
-  await eslintCoreConfigNx(projectName),
-  jsDocsCoreConfig([
-    `packages/${projectName}/src/**/*.ts`,
-    ...jsDocsExclusionPatterns,
-  ]),
-  await typescriptPluginConfig({
-    tsconfig: `packages/${projectName}/tsconfig.lib.json`,
-  }),
 );
diff --git a/code-pushup.preset.ts b/code-pushup.preset.ts
@@ -217,10 +217,7 @@ export const eslintCoreConfigNx = async (
 ): Promise<CoreConfig> => ({
   plugins: [
     projectName
-      ? await eslintPlugin({
-          eslintrc: `packages/${projectName}/eslint.config.js`,
-          patterns: ['.'],
-        })
+      ? await eslintPlugin(`packages/${projectName}/eslint.config.js`)
       : await eslintPlugin(await eslintConfigFromAllNxProjects()),
   ],
   categories: eslintCategories,
diff --git a/packages/ci/project.json b/packages/ci/project.json
@@ -12,9 +12,11 @@
       "dependsOn": [
         "code-pushup-coverage",
         "code-pushup-jsdocs",
-        "code-pushup-typescript"
+        "code-pushup-typescript",
+        "code-pushup-eslint"
       ]
     },
+    "code-pushup-eslint": {},
     "code-pushup-coverage": {},
     "code-pushup-jsdocs": {},
     "code-pushup-typescript": {}
diff --git a/packages/cli/project.json b/packages/cli/project.json
@@ -30,9 +30,11 @@
       "dependsOn": [
         "code-pushup-coverage",
         "code-pushup-jsdocs",
-        "code-pushup-typescript"
+        "code-pushup-typescript",
+        "code-pushup-eslint"
       ]
     },
+    "code-pushup-eslint": {},
     "code-pushup-coverage": {},
     "code-pushup-jsdocs": {},
     "code-pushup-typescript": {}
diff --git a/packages/core/project.json b/packages/core/project.json
@@ -12,9 +12,11 @@
       "dependsOn": [
         "code-pushup-coverage",
         "code-pushup-jsdocs",
-        "code-pushup-typescript"
+        "code-pushup-typescript",
+        "code-pushup-eslint"
       ]
     },
+    "code-pushup-eslint": {},
     "code-pushup-coverage": {},
     "code-pushup-jsdocs": {},
     "code-pushup-typescript": {}
diff --git a/packages/create-cli/project.json b/packages/create-cli/project.json
@@ -11,14 +11,11 @@
       "dependsOn": [
         "code-pushup-coverage",
         "code-pushup-jsdocs",
-        "code-pushup-typescript"
+        "code-pushup-typescript",
+        "code-pushup-eslint"
       ]
     },
-    "exec-node": {
-      "dependsOn": ["build"],
-      "command": "node ./dist/packages/create-cli/src/index.js",
-      "options": {}
-    },
+    "code-pushup-eslint": {},
     "code-pushup-coverage": {},
     "code-pushup-jsdocs": {},
     "code-pushup-typescript": {}
diff --git a/packages/models/project.json b/packages/models/project.json
@@ -8,11 +8,15 @@
       "dependsOn": [
         "code-pushup-coverage",
         "code-pushup-jsdocs",
-        "code-pushup-typescript"
+        "code-pushup-typescript",
+        "code-pushup-eslint"
       ]
     },
     "code-pushup-eslint": {},
     "code-pushup-jsdocs": {},
+    "code-pushup-coverage": {
+      "dependsOn": ["unit-test"]
+    },
     "code-pushup-typescript": {},
     "generate-docs": {
       "command": "npx zod2md --config packages/models/zod2md.config.ts",
diff --git a/packages/nx-plugin/project.json b/packages/nx-plugin/project.json
@@ -46,9 +46,11 @@
       "dependsOn": [
         "code-pushup-coverage",
         "code-pushup-jsdocs",
-        "code-pushup-typescript"
+        "code-pushup-typescript",
+        "code-pushup-eslint"
       ]
     },
+    "code-pushup-eslint": {},
     "code-pushup-coverage": {},
     "code-pushup-jsdocs": {},
     "code-pushup-typescript": {}
diff --git a/packages/plugin-coverage/project.json b/packages/plugin-coverage/project.json
@@ -12,9 +12,11 @@
       "dependsOn": [
         "code-pushup-coverage",
         "code-pushup-jsdocs",
-        "code-pushup-typescript"
+        "code-pushup-typescript",
+        "code-pushup-eslint"
       ]
     },
+    "code-pushup-eslint": {},
     "code-pushup-coverage": {},
     "code-pushup-jsdocs": {},
     "code-pushup-typescript": {}
diff --git a/packages/plugin-eslint/project.json b/packages/plugin-eslint/project.json
@@ -12,9 +12,11 @@
       "dependsOn": [
         "code-pushup-coverage",
         "code-pushup-jsdocs",
-        "code-pushup-typescript"
+        "code-pushup-typescript",
+        "code-pushup-eslint"
       ]
     },
+    "code-pushup-eslint": {},
     "code-pushup-coverage": {},
     "code-pushup-jsdocs": {},
     "code-pushup-typescript": {}
diff --git a/packages/plugin-js-packages/project.json b/packages/plugin-js-packages/project.json
@@ -12,9 +12,11 @@
       "dependsOn": [
         "code-pushup-coverage",
         "code-pushup-jsdocs",
-        "code-pushup-typescript"
+        "code-pushup-typescript",
+        "code-pushup-eslint"
       ]
     },
+    "code-pushup-eslint": {},
     "code-pushup-coverage": {},
     "code-pushup-jsdocs": {},
     "code-pushup-typescript": {}
diff --git a/packages/plugin-jsdocs/project.json b/packages/plugin-jsdocs/project.json
@@ -12,9 +12,11 @@
       "dependsOn": [
         "code-pushup-coverage",
         "code-pushup-jsdocs",
-        "code-pushup-typescript"
+        "code-pushup-typescript",
+        "code-pushup-eslint"
       ]
     },
+    "code-pushup-eslint": {},
     "code-pushup-coverage": {},
     "code-pushup-jsdocs": {},
     "code-pushup-typescript": {}
diff --git a/packages/plugin-lighthouse/project.json b/packages/plugin-lighthouse/project.json
@@ -11,9 +11,11 @@
       "dependsOn": [
         "code-pushup-coverage",
         "code-pushup-jsdocs",
-        "code-pushup-typescript"
+        "code-pushup-typescript",
+        "code-pushup-eslint"
       ]
     },
+    "code-pushup-eslint": {},
     "code-pushup-coverage": {
       "dependsOn": ["unit-test"]
     },
diff --git a/packages/plugin-typescript/project.json b/packages/plugin-typescript/project.json
@@ -12,9 +12,11 @@
       "dependsOn": [
         "code-pushup-coverage",
         "code-pushup-jsdocs",
-        "code-pushup-typescript"
+        "code-pushup-typescript",
+        "code-pushup-eslint"
       ]
     },
+    "code-pushup-eslint": {},
     "code-pushup-coverage": {},
     "code-pushup-jsdocs": {},
     "code-pushup-typescript": {}
diff --git a/packages/utils/project.json b/packages/utils/project.json
@@ -24,12 +24,15 @@
       "dependsOn": [
         "code-pushup-coverage",
         "code-pushup-jsdocs",
-        "code-pushup-typescript"
+        "code-pushup-typescript",
+        "code-pushup-eslint"
       ]
     },
-    "code-pushup-coverage": {},
+    "code-pushup-eslint": {},
     "code-pushup-jsdocs": {},
-    "code-pushup-typescript": {}
+    "code-pushup-coverage": {
+      "dependsOn": ["unit-test", "int-test"]
+    }
   },
   "tags": ["scope:shared", "type:util", "publishable"]
 }
diff --git a/project.json b/project.json
@@ -2,24 +2,16 @@
   "name": "cli-source",
   "$schema": "node_modules/nx/schemas/project-schema.json",
   "targets": {
-    "code-pushup-old": {
-      "dependsOn": [
-        "code-pushup-eslint",
-        "code-pushup-coverage",
-        "code-pushup-typescript",
-        "code-pushup-jsdocs",
-        "code-pushup-js-packages",
-        "code-pushup-lighthouse"
-      ],
+    "code-pushup-central": {
       "executor": "nx:run-commands",
       "options": {
         "command": "node packages/cli/src/index.ts",
         "args": [
           "--no-progress",
           "--verbose",
-          "--config={projectRoot}/code-pushup.old.config.ts",
-          "--cache.read",
-          "--persist.outputDir={projectRoot}/.code-pushup"
+          "--config={projectRoot}/code-pushup.central.config.ts",
+          "--persist.outputDir={projectRoot}/.code-pushup",
+          "--upload.project=cli"
         ],
         "env": {
           "NODE_OPTIONS": "--import tsx",
@@ -40,10 +32,6 @@
         ]
       }
     },
-    "code-pushup-eslint": {},
-    "code-pushup-coverage": {},
-    "code-pushup-jsdocs": {},
-    "code-pushup-typescript": {},
     "code-pushup-js-packages": {},
     "code-pushup-lighthouse": {}
   }
