fix(utils): prevent duplicate log group prefixes in sub-processes

Author: matejchalk

packages/utils/src/lib/logger.int.test.ts

@@ -242,22 +242,6 @@ ${ansis.cyan('└')} ${ansis.green(`Total line coverage is ${ansis.bold('82%')}`
       expect(output).toContain('Completed "ESLint" plugin execution');
     });
 
-    it('should use log group prefix in child loggers', async () => {
-      performanceNowSpy.mockReturnValueOnce(0).mockReturnValueOnce(1234); // group duration: 1.23 s
-
-      await new Logger().group('Running plugin "ESLint"', async () => {
-        new Logger().info(`${ansis.blue('$')} npx eslint . --format=json`);
-        return 'ESLint reported 4 errors and 11 warnings';
-      });
-
-      expect(output).toBe(`
-${ansis.bold.cyan('❯ Running plugin "ESLint"')}
-${ansis.cyan('│')} ${ansis.blue('$')} npx eslint . --format=json
-${ansis.cyan('└')} ${ansis.green('ESLint reported 4 errors and 11 warnings')} ${ansis.gray('(1.23 s)')}
-
-`);
-    });
-
     it('should use workflow commands to group logs in GitHub Actions environment', async () => {
       vi.stubEnv('CI', 'true');
       vi.stubEnv('GITHUB_ACTIONS', 'true');
@@ -911,20 +895,6 @@ ${ansis.red.bold('Cancelled by SIGINT')}
       );
     });
 
-    it('should throw if nesting groups across logger instances', async () => {
-      await expect(
-        new Logger().group('Outer group', async () => {
-          await new Logger().group(
-            'Inner group',
-            async () => 'Inner group complete',
-          );
-          return 'Outer group complete';
-        }),
-      ).rejects.toThrow(
-        'Internal Logger error - nested groups are not supported',
-      );
-    });
-
     it('should throw if creating group while spinner is running', async () => {
       const logger = new Logger();
 

packages/utils/src/lib/logger.ts

@@ -11,8 +11,6 @@ import { settlePromise } from './promises.js';
 type GroupColor = Extract<AnsiColors, 'cyan' | 'magenta'>;
 type CiPlatform = 'GitHub Actions' | 'GitLab CI/CD';
 
-const GROUP_COLOR_ENV_VAR_NAME = 'CP_LOGGER_GROUP_COLOR';
-
 /**
  * Rich logging implementation for Code PushUp CLI, plugins, etc.
  *
@@ -26,11 +24,7 @@ export class Logger {
     : isEnvVarEnabled('GITLAB_CI')
       ? 'GitLab CI/CD'
       : undefined;
-  #groupColor: GroupColor | undefined =
-    process.env[GROUP_COLOR_ENV_VAR_NAME] === 'cyan' ||
-    process.env[GROUP_COLOR_ENV_VAR_NAME] === 'magenta'
-      ? process.env[GROUP_COLOR_ENV_VAR_NAME]
-      : undefined;
+  #groupColor: GroupColor | undefined;
 
   #groupsCount = 0;
   #activeSpinner: Ora | undefined;
@@ -51,7 +45,7 @@ export class Logger {
           text,
           symbol: this.#colorize(this.#groupSymbols.end, this.#groupColor),
         });
-        this.#setGroupColor(undefined);
+        this.#groupColor = undefined;
       } else {
         this.#activeSpinner.fail(text);
       }
@@ -271,7 +265,7 @@ export class Logger {
       this.newline();
     }
 
-    this.#setGroupColor(this.#groupsCount % 2 === 0 ? 'cyan' : 'magenta');
+    this.#groupColor = this.#groupsCount % 2 === 0 ? 'cyan' : 'magenta';
     this.#groupsCount++;
 
     const groupMarkers = this.#createGroupMarkers();
@@ -308,7 +302,7 @@ export class Logger {
     if (endMarker) {
       console.log(endMarker);
     }
-    this.#setGroupColor(undefined);
+    this.#groupColor = undefined;
     this.newline();
 
     if (result.status === 'rejected') {
@@ -366,15 +360,6 @@ export class Logger {
     return ansis.bold(this.#colorize(text, this.#groupColor));
   }
 
-  #setGroupColor(groupColor: GroupColor | undefined) {
-    this.#groupColor = groupColor;
-    if (groupColor) {
-      process.env[GROUP_COLOR_ENV_VAR_NAME] = groupColor;
-    } else {
-      delete process.env[GROUP_COLOR_ENV_VAR_NAME];
-    }
-  }
-
   async #spinner<T>(
     worker: () => Promise<T>,
     messages: {