Skip to content

Conversation

@matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Nov 26, 2025

Related to #888 ... sort of. I want to be able to evaluate our CI logs in a representative environment, which requires completing what @BioPhoton started in #1062.

I split our Code PushUp workflow into 2 distinct jobs:

  • standalone (see logs)
    • basic "all in one" setup
    • single config file at repository root
    • no Nx task dependencies or plugin caching
    • includes all plugins
  • monorepo (see logs)
    • enterprise-level "mega Nx" setup
    • heavily reliant on Nx task graph and plugin caching
    • each package has its own config
    • skips print-config commands by providing configPatterns
    • only includes plugins that make sense on project-level

Each job posts separate PR comments (I added a special jobId to @code-pushup/ci for this use case).

I refactored the code-pushup.preset.ts file to minimize duplication in code-pushup.config.ts files.

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🦾 CI/CD Continuous integration and deployment 🛠️ tooling 🧩 typescript-plugin TypeScript plugin labels Nov 26, 2025
@nx-cloud
Copy link

nx-cloud bot commented Nov 26, 2025

View your CI Pipeline Execution ↗ for commit a61f991

Command Status Duration Result
nx code-pushup -- compare ✅ Succeeded 6s View ↗
nx code-pushup -- ✅ Succeeded 6m 39s View ↗
nx code-pushup -- print-config --output=/home/r... ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-28 17:43:11 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 26, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1154

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1154

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1154

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1154

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1154

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1154

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1154

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1154

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1154

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1154

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1154

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1154

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1154

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1154

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1154

commit: a61f991

@matejchalk matejchalk force-pushed the dogfood-standalone-and-monorepo branch 2 times, most recently from fa86807 to f90a4e4 Compare November 28, 2025 15:11
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit df4cd75 with previous commit d21a99c.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Type Safety 🟢 100 🟡 56 ↓ −44.4
Bug prevention 🟢 100 🟡 67 ↓ −33.3
Miscellaneous 🟢 100 🟡 67 ↓ −33.3
Performance 🔴 36 🔴 41 ↑ +5.4
Code coverage 🟡 89 🟡 89 ↓ −0.1
Documentation 🔴 35 🔴 35 ↓ −0.1
Code style 🟢 100 🟢 100
Security 🔴 43 🔴 43
Updates 🟡 71 🟡 71
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 1 group improved, 👎 4 groups regressed, 👍 5 audits improved, 👎 9 audits regressed, 16 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
TypeScript Problems 🟢 100 🔴 0 ↓ −100
TypeScript Miscellaneous 🟢 100 🟡 67 ↓ −33.3
Lighthouse Performance 🔴 36 🔴 41 ↑ +5.4
Code coverage Code coverage metrics 🟡 89 🟡 89 ↓ −0.1
JSDoc coverage Documentation coverage 🔴 35 🔴 35 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
TypeScript Semantic errors 🟩 passed 🟥 2608 errors ↑ +∞ %
TypeScript No implicit any errors 🟩 passed 🟥 96 errors ↑ +∞ %
TypeScript Syntax errors 🟩 passed 🟥 5 errors ↑ +∞ %
TypeScript Declaration and language service errors 🟩 passed 🟥 2 errors ↑ +∞ %
Lighthouse Total Blocking Time 🟥 2,000 ms 🟥 1,030 ms ↓ −48.6 %
Lighthouse Speed Index 🟥 6.9 s 🟥 6.2 s ↓ −9.1 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.3 s ↑ +7.5 %
Lighthouse Time to Interactive 🟥 13.7 s 🟥 12.4 s ↓ −9.4 %
Code coverage Line coverage 🟨 85.3 % 🟨 84.5 % ↓ −1 %
Code coverage Branch coverage 🟨 87.3 % 🟨 87.1 % ↓ −0.2 %
JSDoc coverage Types coverage 🟥 238 undocumented types 🟥 241 undocumented types ↑ +1.3 %
JSDoc coverage Functions coverage 🟥 557 undocumented functions 🟥 561 undocumented functions ↑ +0.7 %
Code coverage Function coverage 🟩 90.3 % 🟩 90.4 % ↑ +0.1 %
JSDoc coverage Variables coverage 🟥 248 undocumented variables 🟥 245 undocumented variables ↓ −1.2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,020 KiB 🟩 Total size was 2,048 KiB ↑ +1.4 %
Lighthouse Minimizes main-thread work 🟥 12.6 s 🟥 8.9 s ↓ −29.8 %
Lighthouse JavaScript execution time 🟥 5.9 s 🟥 3.6 s ↓ −38.7 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −9.4 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Server Backend Latencies 🟩 1,040 ms 🟩 1,240 ms ↑ +19.2 %
Lighthouse Max Potential First Input Delay 🟥 1,230 ms 🟥 1,080 ms ↓ −12 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 105 KiB 🟥 Potential savings of 94 KiB ↑ +26 %
Lighthouse Avoids an excessive DOM size 🟥 2,242 elements 🟥 2,358 elements ↑ +5.2 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 184 KiB 🟥 Potential savings of 184 KiB ↓ −5.1 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 102 KiB 🟥 Potential savings of 105 KiB ↓ −6 %
Axe Accessibility ARIA hidden element must not be focusable or contain focusable elements 🟩 190 elements 🟩 200 elements ↑ +5.3 %
Axe Accessibility IDs used in ARIA and labels must be unique 🟩 37 elements 🟩 28 elements ↓ −24.3 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 60 ms ↑ +15.6 %
Lighthouse Initial server response time was short 🟩 Root document took 600 ms 🟩 Root document took 600 ms ↓ −0.5 %
Lighthouse Largest Contentful Paint 🟥 11.1 s 🟥 11.1 s ↓ −0.1 %

648 other audits are unchanged.

@matejchalk matejchalk force-pushed the dogfood-standalone-and-monorepo branch from f90a4e4 to b47aa6a Compare November 28, 2025 15:21
@github-actions
Copy link
Contributor

Code PushUp

😐 Code PushUp report is unchanged – compared current commit df4cd75 with previous commit df4cd75.


All of 14 projects are unchanged.

@matejchalk matejchalk marked this pull request as ready for review November 28, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🦾 CI/CD Continuous integration and deployment 🧩 ci 🧩 cli 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling 🧩 typescript-plugin TypeScript plugin 🧩 utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants