Merge pull request #63 from codebar-ag/fix-address-dto

Removed address from AdditionalAddress Request + DTO

Author: StanBarrows

src/Dto/AdditionalAddresses/AdditionalAddressDTO.php

@@ -15,7 +15,6 @@ public function __construct(
         public ?string $name_addition,
         public string $subject,
         public string $description,
-        public ?string $address = null, // deprecated
         public ?string $street_name = null,
         public ?string $house_number = null,
         public ?string $address_addition = null,
@@ -47,7 +46,6 @@ public static function fromArray(array $data): self
             name_addition: Arr::get($data, 'name_addition'),
             subject: Arr::get($data, 'subject'),
             description: Arr::get($data, 'description'),
-            address: Arr::get($data, 'address'),
             street_name: Arr::get($data, 'street_name'),
             house_number: Arr::get($data, 'house_number'),
             address_addition: Arr::get($data, 'address_addition'),

src/Dto/AdditionalAddresses/CreateEditAdditionalAddressDTO.php

@@ -14,7 +14,6 @@ public function __construct(
         public ?string $name_addition,
         public string $subject,
         public string $description,
-        public ?string $address = null, // deprecated
         public ?string $street_name = null,
         public ?string $house_number = null,
         public ?string $address_addition = null,
@@ -45,7 +44,6 @@ public static function fromArray(array $data): self
             name_addition: Arr::get($data, 'name_addition'),
             subject: Arr::get($data, 'subject'),
             description: Arr::get($data, 'description'),
-            address: Arr::get($data, 'address'), // deprecated
             street_name: Arr::get($data, 'street_name'),
             house_number: Arr::get($data, 'house_number'),
             address_addition: Arr::get($data, 'address_addition'),

tests/Fixtures/Saloon/AdditionalAddresses/create-an-additional-address.json

@@ -21,6 +21,6 @@
         "cf-cache-status": "DYNAMIC",
         "Server": "cloudflare"
     },
-    "data": "{\"id\":2,\"name\":\"Test name\",\"name_addition\":null,\"address\":\"Test address\",\"street_name\":null,\"house_number\":null,\"address_addition\":null,\"postcode\":\"12345\",\"city\":\"Test city\",\"country_id\":1,\"subject\":\"Test subject\",\"description\":\"Test description\"}",
+    "data": "{\"id\":2,\"name\":\"Test name\",\"name_addition\":null,\"street_name\":null,\"house_number\":null,\"address_addition\":null,\"postcode\":\"12345\",\"city\":\"Test city\",\"country_id\":1,\"subject\":\"Test subject\",\"description\":\"Test description\"}",
     "context": []
-}
+}

tests/Requests/AdditionalAddresses/CreateAnAdditionalAddressRequestTest.php

@@ -21,8 +21,7 @@
             name_addition: null,
             subject: 'Test subject',
             description: 'Test description',
-            address: 'Test address',
-            postcode: '12345',
+            postcode: 12345,
             city: 'Test city',
             country_id: 1,
         )

tests/Requests/AdditionalAddresses/EditAnAdditionalAddressRequestTest.php

@@ -22,8 +22,7 @@
             name_addition: null,
             subject: 'Test subject edited',
             description: 'Test description edited',
-            address: 'Test address edited',
-            postcode: '12345',
+            postcode: 12345,
             city: 'Test city edited',
             country_id: 1,
         )