WIP

Author: RhysLees

.phpunit.cache/test-results

@@ -2,12 +2,11 @@ includes:
     - phpstan-baseline.neon
 
 parameters:
-    level: 4
+    level: 5
     paths:
         - src
         - config
     tmpDir: build/phpstan
     checkOctaneCompatibility: true
     checkModelProperties: true
-    checkMissingIterableValueType: false
-
+    noEnvCallsOutsideOfConfig: false

phpstan.neon.dist

@@ -24,9 +24,6 @@ public function __construct(
         public ConfigWithCredentials|ConfigWithCredentialsTrustedUser $configuration
     ) {}
 
-    /**
-     * @throws \Exception
-     */
     public function resolveBaseUrl(): string
     {
         return $this->configuration->url.'/DocuWare/Platform';
@@ -79,6 +76,7 @@ protected function getOrCreateNewOAuthToken(): string
         }
 
         // Handle token retrieval for ConfigWithCredentialsTrustedUser
+        // @phpstan-ignore-next-line
         if ($this->configuration instanceof ConfigWithCredentialsTrustedUser) {
             $token = $this->getNewOAuthTokenWithCredentialsTrustedUser();
             DocuWareOAuthLog::dispatch($this->configuration->url, $this->configuration->username, 'Token retrieved from API');

src/Connectors/DocuWareConnector.php

@@ -50,14 +50,14 @@ protected static function convertFields(Collection $fields): Collection
         });
     }
 
-    protected static function convertSuggestions(Collection $suggestions): ?Collection
+    protected static function convertSuggestions(Collection $suggestions): Collection
     {
         return $suggestions->mapWithKeys(function (array $suggestion) {
             return [$suggestion['DBName'] => SuggestionField::fromJson($suggestion)];
         });
     }
 
-    protected static function convertSections(Collection $sections): ?Collection
+    protected static function convertSections(Collection $sections): Collection
     {
         return $sections->mapWithKeys(function (array $section) {
             return [$section['Id'] => Section::fromJson($section)];

src/DTO/Documents/Document.php

@@ -3,7 +3,6 @@
 namespace CodebarAg\DocuWare\Requests\Documents\UpdateIndexValues;
 
 use CodebarAg\DocuWare\DTO\Documents\DocumentIndex\PrepareDTO;
-use CodebarAg\DocuWare\Exceptions\UnableToUpdateFields;
 use CodebarAg\DocuWare\Responses\Documents\UpdateIndexValues\UpdateIndexValuesResponse;
 use Illuminate\Support\Collection;
 use Saloon\Contracts\Body\HasBody;
@@ -18,9 +17,6 @@ class UpdateIndexValues extends Request implements HasBody
 
     protected Method $method = Method::PUT;
 
-    /**
-     * @throws UnableToUpdateFields
-     */
     public function __construct(
         protected readonly string $fileCabinetId,
         protected readonly string $documentId,

src/Requests/Documents/UpdateIndexValues/UpdateIndexValues.php

@@ -16,7 +16,7 @@ class URL
      */
     public static function format(string $string): string
     {
-        $padding = Str::substrCount($string, '=');
+        $padding = (string) Str::substrCount($string, '=');
 
         return Str::of($string)
             ->replace('+', '-')