Skip to content

delete function in BST not working while deleting first element if its the lowest #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snehA5e8a opened this issue Jul 23, 2024 · 1 comment

Comments

@snehA5e8a
Copy link

https://github.com/codebasics/data-structures-algorithms-python/blob/master/data_structures/9_Binary_Tree_2/binary_tree_part_2.py
image

@RohanMehraa
Copy link

RohanMehraa commented May 5, 2025

Use the following code, it covers all the cases (root deletion, as well as if there's only one element in the tree, i.e. root), if there are only left subtree to the root and if there is only right subtree to the root:
HOPE THAT HELPS! :) :)

def delete_node(self, value):
    if value < self.data:
        if self.left:
            self.left = self.left.delete_node(value)

    elif value > self.data:
        if self.right:
            self.right = self.right.delete_node(value)

    else:
        if self.left is None and self.right is None:
            self.data = None
            return None
        
        else:  
            if self.right:
                min_val = self.right.find_min()
                self.data = min_val
                self.right = self.right.delete_node(min_val)

            elif self.left:
                max_val = self.left.find_max()
                self.data = max_val
                self.left = self.left.delete_node(max_val)

    return self

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants