Skip to content

Commit 03bdad6

Browse files
committed
Improve readability
1 parent 1eb0214 commit 03bdad6

File tree

3 files changed

+24
-24
lines changed

3 files changed

+24
-24
lines changed

CalendarKitDemo/CalendarApp/CustomCalendarExampleController.swift

+7-7
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@ class CustomCalendarExampleController: DayViewController {
4545
UIColor.green,
4646
UIColor.red]
4747

48-
private lazy var rangeFormatter: DateIntervalFormatter = {
49-
let fmt = DateIntervalFormatter()
50-
fmt.dateStyle = .none
51-
fmt.timeStyle = .short
48+
private lazy var dateIntervalFormatter: DateIntervalFormatter = {
49+
let dateIntervalFormatter = DateIntervalFormatter()
50+
dateIntervalFormatter.dateStyle = .none
51+
dateIntervalFormatter.timeStyle = .short
5252

53-
return fmt
53+
return dateIntervalFormatter
5454
}()
5555

5656
override func loadView() {
@@ -93,7 +93,7 @@ class CustomCalendarExampleController: DayViewController {
9393
let timezone = dayView.calendar.timeZone
9494
print(timezone)
9595

96-
info.append(rangeFormatter.string(from: event.dateInterval.start, to: event.dateInterval.end))
96+
info.append(dateIntervalFormatter.string(from: event.dateInterval.start, to: event.dateInterval.end))
9797
event.text = info.reduce("", {$0 + $1 + "\n"})
9898
event.color = colors[Int(arc4random_uniform(UInt32(colors.count)))]
9999
event.isAllDay = Int(arc4random_uniform(2)) % 2 == 0
@@ -168,7 +168,7 @@ class CustomCalendarExampleController: DayViewController {
168168

169169
var info = data[Int(arc4random_uniform(UInt32(data.count)))]
170170

171-
info.append(rangeFormatter.string(from: event.dateInterval)!)
171+
info.append(dateIntervalFormatter.string(from: event.dateInterval)!)
172172
event.text = info.reduce("", {$0 + $1 + "\n"})
173173
event.color = colors[Int(arc4random_uniform(UInt32(colors.count)))]
174174
event.editedEvent = event

Sources/Header/DayHeaderView.swift

+11-11
Original file line numberDiff line numberDiff line change
@@ -57,27 +57,27 @@ public final class DayHeaderView: UIView, DaySelectorDelegate, DayViewStateUpdat
5757

5858
private func configurePagingViewController() {
5959
let selectedDate = Date()
60-
let vc = makeSelectorController(startDate: beginningOfWeek(selectedDate))
61-
vc.selectedDate = selectedDate
62-
currentWeekdayIndex = vc.selectedIndex
60+
let daySelectorController = makeSelectorController(startDate: beginningOfWeek(selectedDate))
61+
daySelectorController.selectedDate = selectedDate
62+
currentWeekdayIndex = daySelectorController.selectedIndex
6363

6464
let leftToRight = UIView.userInterfaceLayoutDirection(for: semanticContentAttribute) == .leftToRight
6565
let direction: UIPageViewController.NavigationDirection = leftToRight ? .forward : .reverse
6666

67-
pagingViewController.setViewControllers([vc], direction: direction, animated: false, completion: nil)
67+
pagingViewController.setViewControllers([daySelectorController], direction: direction, animated: false, completion: nil)
6868
pagingViewController.dataSource = self
6969
pagingViewController.delegate = self
7070
addSubview(pagingViewController.view!)
7171
}
7272

7373
private func makeSelectorController(startDate: Date) -> DaySelectorController {
74-
let new = DaySelectorController()
75-
new.calendar = calendar
76-
new.transitionToHorizontalSizeClass(currentSizeClass)
77-
new.updateStyle(style.daySelector)
78-
new.startDate = startDate
79-
new.delegate = self
80-
return new
74+
let daySelectorController = DaySelectorController()
75+
daySelectorController.calendar = calendar
76+
daySelectorController.transitionToHorizontalSizeClass(currentSizeClass)
77+
daySelectorController.updateStyle(style.daySelector)
78+
daySelectorController.startDate = startDate
79+
daySelectorController.delegate = self
80+
return daySelectorController
8181
}
8282

8383
private func beginningOfWeek(_ date: Date) -> Date {

Sources/Timeline/TimelinePagerView.swift

+6-6
Original file line numberDiff line numberDiff line change
@@ -470,19 +470,19 @@ public final class TimelinePagerView: UIView, UIGestureRecognizerDelegate, UIScr
470470
public func pageViewController(_ pageViewController: UIPageViewController, viewControllerBefore viewController: UIViewController) -> UIViewController? {
471471
guard let containerController = viewController as? TimelineContainerController else {return nil}
472472
let previousDate = calendar.date(byAdding: .day, value: -1, to: containerController.timeline.date)!
473-
let vc = configureTimelineController(date: previousDate)
473+
let timelineContainerController = configureTimelineController(date: previousDate)
474474
let offset = (pageViewController.viewControllers?.first as? TimelineContainerController)?.container.contentOffset
475-
vc.pendingContentOffset = offset
476-
return vc
475+
timelineContainerController.pendingContentOffset = offset
476+
return timelineContainerController
477477
}
478478

479479
public func pageViewController(_ pageViewController: UIPageViewController, viewControllerAfter viewController: UIViewController) -> UIViewController? {
480480
guard let containerController = viewController as? TimelineContainerController else {return nil}
481481
let nextDate = calendar.date(byAdding: .day, value: 1, to: containerController.timeline.date)!
482-
let vc = configureTimelineController(date: nextDate)
482+
let timelineContainerController = configureTimelineController(date: nextDate)
483483
let offset = (pageViewController.viewControllers?.first as? TimelineContainerController)?.container.contentOffset
484-
vc.pendingContentOffset = offset
485-
return vc
484+
timelineContainerController.pendingContentOffset = offset
485+
return timelineContainerController
486486
}
487487

488488
// MARK: UIPageViewControllerDelegate

0 commit comments

Comments
 (0)