Skip to content

Commit 863eecc

Browse files
authored
fix: Change replaceChildren access to safe (#94)
This PR removes the defined assertion from a couple lines of code and optional chains the param in case it doesn't exist
1 parent 662b957 commit 863eecc

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/content/github/pr/main.tsx

+6-6
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ async function main() {
2626
document.addEventListener("soft-nav:end", execute);
2727
await execute();
2828
} catch (e) {
29-
Sentry.captureException(e)
30-
throw e
29+
Sentry.captureException(e);
30+
throw e;
3131
}
3232
}
3333

@@ -100,7 +100,7 @@ const handleToggleClick: React.MouseEventHandler = (event) => {
100100
};
101101

102102
function updateContainer(head: number, patch: number, change: number) {
103-
const parent = document.getElementById("coverage-report-data")!;
103+
const parent = document.getElementById("coverage-report-data");
104104

105105
const element = (
106106
<div className="codecov-flex codecov-items-center">
@@ -119,17 +119,17 @@ function updateContainer(head: number, patch: number, change: number) {
119119
</div>
120120
);
121121

122-
parent.replaceChildren(element);
122+
parent?.replaceChildren(element);
123123
}
124124

125125
function showError() {
126-
const parent = document.getElementById("coverage-report-data")!;
126+
const parent = document.getElementById("coverage-report-data");
127127

128128
const element = (
129129
<div className="my-auto mr-6">Coverage report not available</div>
130130
);
131131

132-
parent.replaceChildren(element);
132+
parent?.replaceChildren(element);
133133
}
134134

135135
function transformReport(filesReport: any) {

0 commit comments

Comments
 (0)