Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert exclude folders to strs #595

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix: convert exclude folders to strs #595

merged 1 commit into from
Jan 16, 2025

Conversation

thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Jan 16, 2025 •
edited
Loading

fixes #482

@sentry-io Sentry.io
Copy link

sentry-io bot commented Jan 16, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: codecov_cli/services/upload/file_finder.py

Function Unhandled Issue
find_files TypeError: can only concatenate list (not "tuple") to list codecov_cli.services.upload.file_finder in ...
Event Count: 4

Did you find this useful? React with a 👍 or 👎

@github-actions GitHub Actions
Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
3555 5 3550 0
View the top 3 failed tests by shortest run time 
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@thomasrockhu-codecov thomasrockhu-codecov merged commit 15d869d into main Jan 16, 2025
20 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the th/fix-exclusion-folders branch January 16, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trent-codecov trent-codecov trent-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"upload-process --exclude" flags don't seem to work when uploading reports
2 participants
@thomasrockhu-codecov @trent-codecov