Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test-and-deploy mac builds #1775

Merged
merged 17 commits into from
Nov 13, 2024
Merged

fix: test-and-deploy mac builds #1775

merged 17 commits into from
Nov 13, 2024

Conversation

thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Nov 11, 2024 •
edited
Loading

fixes #1773

@thomasrockhu-codecov thomasrockhu-codecov requested a review from a team as a code owner November 11, 2024 19:13
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (848c495) to head (c09969b).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1775      +/-   ##
==========================================
+ Coverage   92.56%   92.78%   +0.22%     
==========================================
  Files          36       36              
  Lines        1358     1358              
  Branches      273      273              
==========================================
+ Hits         1257     1260       +3     
+ Misses         70       68       -2     
+ Partials       31       30       -1
Flag Coverage Δ
aarch64 92.56% <ø> (ø)
aarch64-without-git 92.56% <ø> (ø)
alpine 92.78% <ø> (+0.22%) ⬆️
alpine-proxy 92.56% <ø> (ø)
alpine-without-git 92.78% <ø> (+0.22%) ⬆️
linux 92.56% <ø> (ø)
linux-without-git 92.56% <ø> (ø)
macos 92.56% <ø> (ø)
macos-arm64 92.56% <ø> (?)
macos-arm64-without-git 92.56% <ø> (?)
macos-without-git 92.56% <ø> (ø)
macos-x64 92.56% <ø> (?)
macos-x64-without-git 92.56% <ø> (?)
windows 92.56% <ø> (ø)
windows-without-git 92.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@thomasrockhu-codecov thomasrockhu-codecov changed the title fix: add in proper mac runs fix: test-and-deploy mac builds Nov 13, 2024
trent-codecov
trent-codecov approved these changes Nov 13, 2024
View reviewed changes
Copy link

@trent-codecov trent-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add this to our releaser?

@thomasrockhu-codecov thomasrockhu-codecov merged commit b135fbf into main Nov 13, 2024
39 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the th/fix-test-and-deploy branch November 13, 2024 17:39
@thomasrockhu-codecov
Copy link
Contributor Author

@trent-codecov nope, probably not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trent-codecov trent-codecov trent-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test and deploy workflow is broken
2 participants
@thomasrockhu-codecov @trent-codecov