Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 1-1 interview using webRTC #77

Open
RohankumarM opened this issue Mar 13, 2021 · 11 comments
Open

Adding 1-1 interview using webRTC #77

RohankumarM opened this issue Mar 13, 2021 · 11 comments

Comments

@RohankumarM
Copy link
Contributor

RohankumarM commented Mar 13, 2021

It takes a lot of money to invest just to prepare yourself for an interview so why not users get a chance to interview each other by sharing their video, audio, and screen in a 1 - 1 fashion.

We could use technology like WebRTC to implement this feature. The interview process will not be limited to just solving data structures and algorithms related problems but could include much more.

@Itsaadarsh
Copy link

Yes, @RohankumarM this sounds great as I have previously worked with webRTC technology where I used SFU architecture to build multi-party audio rooms. So if the maintainers want this feature to be integrated into the platform I'd glad to work on it.

And as it is going to have 1-1 room there will not be a load on our servers too as we can make use of P2P architecture (Peer-To-Peer) which is the core fundamental of webRTC.

@Jeevan-Kiran-Lenka
Copy link
Contributor

@Itsaadarsh I very much agree with this idea

@RohankumarM
Copy link
Contributor Author

Definitely @Itsaadarsh. I have also have worked with WebRTC and I just love its architecture and I think this feature would be in demand. But before moving ahead, we just need to make sure the UI of this feature is user-friendly because that will be the main factor.

@Itsaadarsh
Copy link

Hey @Abhishek-kumar09, how do we get started with implementing this feature? Like do we wait for the whole UI/UX to be completed or we just start building this feature on the go? And on the other hand, we would also need to make a few commits on the edu-server repository in order to build this feature. Because the P2P architecture requires an initial handshake to take place which will be processed by our server.

@Abhishek-kumar09
Copy link
Contributor

You can start working without design, I have added the making of design of interview session page in the task pipeline. It will be available soon.

But for now we can start working on the actual problem without thinking of designs.

we would also need to make a few commits on the edu-server repository

yes, sure. It is built on nestJs and typescript. Let me know if you need some help with that.

@Itsaadarsh
Copy link

Alright then I'll get started right away, and can you also assign this to me?

@RohankumarM
Copy link
Contributor Author

@Itsaadarsh If you need any help you can definitely reach out to me.

@Abhishek-kumar09
Copy link
Contributor

Hi @RohankumarM Any specific reason for closing this issue? We should close this once the feature is merged in main code.

@RohankumarM
Copy link
Contributor Author

@Abhishek-kumar09 I hit close by mistake. No worries. Eargerly waiting for the feature to be added.

@Itsaadarsh
Copy link

@RohankumarM The work has already begun client-side logic is mostly done, I just need to figure out nestjs on the server-side and how to use WebSockets in nestjs once I figure that out I'll send a PR.

@RohankumarM
Copy link
Contributor Author

@Itsaadarsh I hope you and your family are in great health. Just reaching to check with you about any updates on this feature? Just curious. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants