Skip to content

Fix unlocalized texts and typo in update avatar alerts #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix unlocalized texts and typo in update avatar alerts #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions i18n/locales/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ export default {
connect_internet_to_update: 'connect the internet to update',
for_checking_in_with_qr: 'for checking in with QR Code',
press_to_confirm: 'Confirm',
can_not_change_picture: 'Can not change picture',
can_change_pic_again_in: 'You can change picture again in ',
can_not_change_picture: 'Cannot change picture',
can_change_pic_again_in: 'You can change picture again in',
day_s: 'day(s)',
are_you_sure: 'Are you sure?',
after_changed_pic_you_will_not_be_able_to_change_until:
Expand Down
4 changes: 2 additions & 2 deletions src/navigations/3-MainApp/MainApp/UpdateProfileButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@ export const UpdateProfileButton = ({ width, style, onChange }) => {
const day = DEFAULT_PERIODS - daySinceUpdated
Alert.alert(
I18n.t('can_not_change_picture'),
'คุณจะสามารถเปลี่ยนรูปได้อีกใน ' + day + I18n.t('day_s'),
I18n.t('can_change_pic_again_in') + ' ' + day + ' ' + I18n.t('day_s'),
)
} else {
navigation.navigate('MainAppFaceCamera', {
setUri: uri => {
if (daySinceCreated >= 3) {
Alert.alert(
I18n.t('are_you_sure'),
`I18n.t('after_changed_pic_you_will_not_be_able_to_change_until') ${DEFAULT_PERIODS} I18n.t('day_s_have_passed')`,
`${I18n.t('after_changed_pic_you_will_not_be_able_to_change_until')} ${DEFAULT_PERIODS} ${I18n.t('day_s_have_passed')}`,
[
{ text: I18n.t('cancel'), style: 'cancel' },
{
Expand Down