refactor: fix property.unusedType errors (#9516)

paulbalandan · web-flow · commit ea2ee243c773 · 2025-04-13T20:24:17.000+08:00
diff --git a/tests/system/HTTP/MessageTest.php b/tests/system/HTTP/MessageTest.php
@@ -25,7 +25,7 @@
 #[Group('Others')]
 final class MessageTest extends CIUnitTestCase
 {
-    private ?Message $message;
+    private Message $message;
 
     protected function setUp(): void
     {
diff --git a/tests/system/HTTP/NegotiateTest.php b/tests/system/HTTP/NegotiateTest.php
@@ -25,8 +25,8 @@
 #[Group('Others')]
 final class NegotiateTest extends CIUnitTestCase
 {
-    private ?IncomingRequest $request;
-    private ?Negotiate $negotiate;
+    private IncomingRequest $request;
+    private Negotiate $negotiate;
 
     protected function setUp(): void
     {
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -1,4 +1,4 @@
-# total 3608 errors
+# total 3605 errors
 includes:
     - argument.type.neon
     - assign.propertyType.neon
@@ -34,7 +34,6 @@ includes:
     - property.protected.neon
     - property.readOnlyByPhpDocAssignOutOfClass.neon
     - property.readOnlyByPhpDocDefaultValue.neon
-    - property.unusedType.neon
     - staticMethod.notFound.neon
     - ternary.shortNotAllowed.neon
     - varTag.type.neon
diff --git a/utils/phpstan-baseline/property.unusedType.neon b/utils/phpstan-baseline/property.unusedType.neon

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@`
`25`	`25`	`#[Group('Others')]`
`26`	`26`	`final class MessageTest extends CIUnitTestCase`
`27`	`27`	`{`
`28`		`- private ?Message $message;`
	`28`	`+ private Message $message;`
`29`	`29`
`30`	`30`	`protected function setUp(): void`
`31`	`31`	`{`
Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,8 @@`
`25`	`25`	`#[Group('Others')]`
`26`	`26`	`final class NegotiateTest extends CIUnitTestCase`
`27`	`27`	`{`
`28`		`- private ?IncomingRequest $request;`
`29`		`- private ?Negotiate $negotiate;`
	`28`	`+ private IncomingRequest $request;`
	`29`	`+ private Negotiate $negotiate;`
`30`	`30`
`31`	`31`	`protected function setUp(): void`
`32`	`32`	`{`