Skip to content

Commit ed5d080

Browse files
authored
refactor: fix phpstan no type specified SaveModelTest (#10032)
* refactor: fix phpstan no type specified SaveModelTest * remove unused properties
1 parent a37cdf3 commit ed5d080

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

tests/system/Models/SaveModelTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,6 @@ public function testSaveNewEntityWithDate(): void
291291
protected $returnType = 'object';
292292
protected $useSoftDeletes = true;
293293
protected $dateFormat = 'date';
294-
public $name = '';
295294
};
296295

297296
$entity->name = 'Mark';
@@ -370,7 +369,6 @@ public function testUseAutoIncrementSetToFalseSaveObject(): void
370369
public function testSaveNewEntityWithMappedPrimaryKey(): void
371370
{
372371
$entity = new class () extends Entity {
373-
protected string $name;
374372
protected $attributes = [
375373
'id' => null,
376374
'name' => null,

utils/phpstan-baseline/loader.neon

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# total 2063 errors
1+
# total 2062 errors
22

33
includes:
44
- argument.type.neon

utils/phpstan-baseline/missingType.property.neon

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# total 48 errors
1+
# total 47 errors
22

33
parameters:
44
ignoreErrors:
@@ -236,8 +236,3 @@ parameters:
236236
message: '#^Property CodeIgniter\\Database\\Live\\MySQLi\\NumberNativeTest\:\:\$tests has no type specified\.$#'
237237
count: 1
238238
path: ../../tests/system/Database/Live/MySQLi/NumberNativeTest.php
239-
240-
-
241-
message: '#^Property CodeIgniter\\Model@anonymous/tests/system/Models/SaveModelTest\.php\:286\:\:\$name has no type specified\.$#'
242-
count: 1
243-
path: ../../tests/system/Models/SaveModelTest.php

0 commit comments

Comments
 (0)