From 8426e971a86c43aa5a0b104ef6a19f3818b099d9 Mon Sep 17 00:00:00 2001 From: Faur Ioan-Aurel Date: Mon, 10 Mar 2025 22:27:23 +0200 Subject: [PATCH 1/2] fix: release notes formatting - gh cli (gh release create) does not need \n and \r to be encoded as it should correctly interpret raw newlines from files. --- .github/workflows/build.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 70187f5..f3908b4 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -69,12 +69,9 @@ jobs: VERSION="$(echo "$PROPERTIES" | grep "^version:" | cut -f2- -d ' ')" NAME="$(echo "$PROPERTIES" | grep "^group:" | cut -f2- -d ' ')" CHANGELOG="$(./gradlew getChangelog --unreleased --no-header --console=plain -q)" - CHANGELOG="${CHANGELOG//'%'/'%25'}" - CHANGELOG="${CHANGELOG//$'\n'/'%0A'}" - CHANGELOG="${CHANGELOG//$'\r'/'%0D'}" echo "version=$VERSION" >> $GITHUB_OUTPUT echo "name=$NAME" >> $GITHUB_OUTPUT - echo "changelog=$CHANGELOG" >> $GITHUB_OUTPUT + echo "$CHANGELOG" > RELEASE_NOTES.md # Run plugin build - name: Run Build @@ -124,7 +121,6 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | - echo "${{ needs.build.outputs.changelog }}" > RELEASE_NOTES.md gh release create v${{ needs.build.outputs.version }} \ --draft \ --target ${GITHUB_REF_NAME} \ From 5ca5d99e1a74211c23f2d4b1be723b0ab766c848 Mon Sep 17 00:00:00 2001 From: Faur Ioan-Aurel Date: Mon, 10 Mar 2025 23:09:12 +0200 Subject: [PATCH 2/2] fix: make zip available to download from draft release - easier to find - needs to download artifacts uploaded in the build job --- .github/workflows/build.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f3908b4..ecb4f5f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -116,13 +116,19 @@ jobs: --jq '.[] | select(.draft == true) | .id' \ | xargs -I '{}' gh api -X DELETE repos/${{ github.repository }}/releases/{} + - name: Download Build Artifacts + uses: actions/download-artifact@v4 + with: + name: release-artifacts + path: artifacts/ + # Create new release draft - which is not publicly visible and requires manual acceptance - name: Create Release Draft env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | gh release create v${{ needs.build.outputs.version }} \ - --draft \ + --draft artifacts/* \ --target ${GITHUB_REF_NAME} \ --title "v${{ needs.build.outputs.version }}" \ --notes-file RELEASE_NOTES.md